Skip to content

[AESH-323] Files are still created in /tmp/ even if logging is disabled. #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2015
Merged

[AESH-323] Files are still created in /tmp/ even if logging is disabled. #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 21 additions & 16 deletions src/main/java/org/jboss/aesh/util/LoggerUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,25 +34,30 @@ public class LoggerUtil {
*/
public static synchronized Logger getLogger(String name) {
if(logHandler == null) {
try {
File logFile = new File(Settings.getInstance().getLogFile());
if(logFile.getParentFile() != null && !logFile.getParentFile().isDirectory()) {
if(!logFile.getParentFile().mkdirs()) {
//if creating dirs failed, just create a logger without a file handler
return Logger.getLogger(name);
if (!Settings.getInstance().isLogging()) {
logHandler = new ConsoleHandler();
logHandler.setFormatter(new SimpleFormatter());
} else {
try {
File logFile = new File(Settings.getInstance().getLogFile());
if(logFile.getParentFile() != null && !logFile.getParentFile().isDirectory()) {
if(!logFile.getParentFile().mkdirs()) {
//if creating dirs failed, just create a logger without a file handler
return Logger.getLogger(name);
}
}
else if(logFile.isDirectory()) {
Settings.getInstance().setLogFile(Settings.getInstance().getLogFile() + Config.getPathSeparator() + "aesh.log");
}
logHandler = new FileHandler(Settings.getInstance().getLogFile());
logHandler.setFormatter(new SimpleFormatter());
}
else if(logFile.isDirectory()) {
Settings.getInstance().setLogFile(Settings.getInstance().getLogFile()+ Config.getPathSeparator()+"aesh.log");
catch (IOException e) {
//just use a consolehandler, set level to severe..
logHandler = new ConsoleHandler();
logHandler.setFormatter(new SimpleFormatter());
logHandler.setLevel(Level.SEVERE);
}
logHandler = new FileHandler(Settings.getInstance().getLogFile());
logHandler.setFormatter(new SimpleFormatter());
}
catch (IOException e) {
//just use a consolehandler, set level to severe..
logHandler = new ConsoleHandler();
logHandler.setFormatter(new SimpleFormatter());
logHandler.setLevel(Level.SEVERE);
}
}

Expand Down