Add bundles for morphisms over binary relations #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the ping @MatthewDaggitt! Question: I didn't spot the "smart constructor" for Poset homomorphisms that we discussed back then (see last part of #1407). Did I miss it?
Might be worth including in this PR since it's mentioned in the description of the issue. Or maybe you wanna open a separate issue for this? |
Thanks for the spot! Yup added it as |
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1407.
Pinging @JacquesCarette and @sstucki to let you know that this can be used to undo some of the ugliness I introduced in agda/agda-categories#243 when
v1.6releases.Unfortunately I had to remove the module-level arguments in the files I introduced last release, but I think it's unlikely anyone has got round to using them seriously yet!