[ refactor ] Data.AVL's map should be polymorphic #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a common pain-point as witnessed by the following SO questions: https://stackoverflow.com/questions/21369719/functor-instance-for-data-avl https://stackoverflow.com/questions/47367747/data-avl-map-that-changes-value-type This does not introduce anything new, it mostly splits up Data.AVL into submodules Data.AVL.(Key|Height|Indexed) which are parameterised by nothing more than what they need. The type of `map` changes from `(forall k. V k -> Vk) -> Tree -> Tree` to `(forall k. V k -> W k) -> Tree V -> Tree W`. We require 1 extra type annotation in README.AVL
|
Great! |
gallais
added a commit
that referenced
this pull request
Feb 20, 2018
This does not introduce anything new, it mostly splits up Data.AVL into submodules Data.AVL.(Key|Height|Indexed) which are parameterised by nothing more than what they need.
gallais
added a commit
that referenced
this pull request
Feb 23, 2018
This does not introduce anything new, it mostly splits up Data.AVL into submodules Data.AVL.(Key|Height|Indexed) which are parameterised by nothing more than what they need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a common pain-point as witnessed by the following SO
questions:
https://stackoverflow.com/questions/21369719/functor-instance-for-data-avl
https://stackoverflow.com/questions/47367747/data-avl-map-that-changes-value-type
This does not introduce anything new, it mostly splits up Data.AVL
into submodules Data.AVL.(Key|Height|Indexed) which are parameterised
by nothing more than what they need.
The type of
mapchanges from(forall k. V k -> Vk) -> Tree -> Treeto
(forall k. V k -> W k) -> Tree V -> Tree W. We require 1 extratype annotation in README.AVL