Release 3.0.0: fix core issues and add new v3 zendesk endpoints

[rsbowers]

No description provided.

[todo]

can we get customer URL or timestamps??

magento_extension/src/app/code/community/Zendesk/Zendesk/Helper/Data.php

Lines 475 to 480 in d81ef13

	// TODO: can we get customer URL or timestamps??
	return $customer;
	}
	protected function formatAddress($address)

---

This comment was generated by todo based on a TODO comment in d81ef13 in #164. cc @agnostack.

[todo]

get without tax

magento_extension/src/app/code/community/Zendesk/Zendesk/Helper/Data.php

Lines 569 to 574 in d81ef13

	'without_tax' => $this->formatPrice($order->getGrandTotal() - $order->getTaxAmount(), $currency), // TODO: get without tax
	'tax' => $this->formatPrice($order->getTaxAmount(), $currency) // TODO: get tax
	),
	'timestamps' => array(
	'created_at' => $order->getCreatedAt(),
	'updated_at' => $order->getUpdatedAt(),

---

This comment was generated by todo based on a TODO comment in d81ef13 in #164. cc @agnostack.

[todo]

get tax

magento_extension/src/app/code/community/Zendesk/Zendesk/Helper/Data.php

Lines 570 to 575 in d81ef13

	'tax' => $this->formatPrice($order->getTaxAmount(), $currency) // TODO: get tax
	),
	'timestamps' => array(
	'created_at' => $order->getCreatedAt(),
	'updated_at' => $order->getUpdatedAt(),
	)

---

This comment was generated by todo based on a TODO comment in d81ef13 in #164. cc @agnostack.

[todo]

grab authorization as well

magento_extension/src/app/code/community/Zendesk/Zendesk/Helper/Data.php

Lines 667 to 672 in d81ef13

	$transaction = $payment->lookupTransaction($lastTransId, 'capture'); // TODO grab authorization as well
	}
	if (!empty($transaction)) {
	$transactionData = $transaction->getData();
	}

---

This comment was generated by todo based on a TODO comment in d81ef13 in #164. cc @agnostack.

[todo]

validate this is the correct value

magento_extension/src/app/code/community/Zendesk/Zendesk/Helper/Data.php

Lines 677 to 682 in d81ef13

	'id' => $transactionData['transaction_id'], //TODO validate this is the correct value
	'type' => $transactionData['txn_type'], //TODO is this only always payment? or can this be refund?
	'reference' => $transactionData['txn_id'], //TODO validate this is the correct value
	'gateway' => $gateway, //TODO validate this is the correct value
	'status' => $payment->getCcCidStatus(), //TODO validate this is the correct value
	'meta' => array(

---

This comment was generated by todo based on a TODO comment in d81ef13 in #164. cc @agnostack.

[todo]

is this only always payment? or can this be refund?

magento_extension/src/app/code/community/Zendesk/Zendesk/Helper/Data.php

Lines 678 to 683 in d81ef13

	'type' => $transactionData['txn_type'], //TODO is this only always payment? or can this be refund?
	'reference' => $transactionData['txn_id'], //TODO validate this is the correct value
	'gateway' => $gateway, //TODO validate this is the correct value
	'status' => $payment->getCcCidStatus(), //TODO validate this is the correct value
	'meta' => array(
	'display_price' => $this->formatPrice($transactionAmount, $currency),

---

This comment was generated by todo based on a TODO comment in d81ef13 in #164. cc @agnostack.

[todo]

validate this is the correct value

magento_extension/src/app/code/community/Zendesk/Zendesk/Helper/Data.php

Lines 679 to 684 in d81ef13

	'reference' => $transactionData['txn_id'], //TODO validate this is the correct value
	'gateway' => $gateway, //TODO validate this is the correct value
	'status' => $payment->getCcCidStatus(), //TODO validate this is the correct value
	'meta' => array(
	'display_price' => $this->formatPrice($transactionAmount, $currency),
	'timestamps' => array(

---

This comment was generated by todo based on a TODO comment in d81ef13 in #164. cc @agnostack.

[todo]

validate this is the correct value

magento_extension/src/app/code/community/Zendesk/Zendesk/Helper/Data.php

Lines 680 to 685 in d81ef13

	'gateway' => $gateway, //TODO validate this is the correct value
	'status' => $payment->getCcCidStatus(), //TODO validate this is the correct value
	'meta' => array(
	'display_price' => $this->formatPrice($transactionAmount, $currency),
	'timestamps' => array(
	'created_at' => $order->getCreatedAt(),

---

This comment was generated by todo based on a TODO comment in d81ef13 in #164. cc @agnostack.

[todo]

validate this is the correct value

magento_extension/src/app/code/community/Zendesk/Zendesk/Helper/Data.php

Lines 681 to 686 in d81ef13

	'status' => $payment->getCcCidStatus(), //TODO validate this is the correct value
	'meta' => array(
	'display_price' => $this->formatPrice($transactionAmount, $currency),
	'timestamps' => array(
	'created_at' => $order->getCreatedAt(),
	'updated_at' => $order->getUpdatedAt(),

---

This comment was generated by todo based on a TODO comment in d81ef13 in #164. cc @agnostack.

[todo]

!!!!!!!: read version from config.xml

magento_extension/src/app/code/community/Zendesk/Zendesk/controllers/ApiController.php

Lines 23 to 28 in d81ef13

	// TODO!!!!!!!: read version from config.xml
	// $configSettings = Mage::getSingleton('Zendesk_Zendesk/config');
	// Mage::log(json_encode($configSettings), null, 'zendesk.log');
	$this->getResponse()->setHeader('X-Extension-Version', '3.0.0');
	return $this;
	}

---

This comment was generated by todo based on a TODO comment in d81ef13 in #164. cc @agnostack.

[todo]

rename to searchOrdersAction?

magento_extension/src/app/code/community/Zendesk/Zendesk/controllers/ApiController.php

Lines 406 to 411 in d81ef13

	// TODO: rename to searchOrdersAction?
	public function searchOrdersAction()
	{
	if(!$this->_authorise()) {
	return $this;
	}

---

This comment was generated by todo based on a TODO comment in d81ef13 in #164. cc @agnostack.

[todo]

!!: implement this method

magento_extension/src/app/code/community/Zendesk/Zendesk/controllers/ApiController.php

Lines 471 to 476 in d81ef13

	// TODO!!: implement this method
	$info = Mage::helper('zendesk')->getOrderDetailExtended($order);
	$this->getResponse()
	->setBody(json_encode($info))
	->setHttpResponseCode(200)

---

This comment was generated by todo based on a TODO comment in d81ef13 in #164. cc @agnostack.

[todo]

does this bring back guest cutsomers

magento_extension/src/app/code/community/Zendesk/Zendesk/controllers/ApiController.php

Lines 596 to 601 in d81ef13

	// TODO does this bring back guest cutsomers
	foreach($customerFilters as $customerKey => $customerValue) {
	$customerCollection->addFieldToFilter($customerKey, $customerValue);
	}
	foreach($generalFilters as $generalKey => $generalValue) {

---

This comment was generated by todo based on a TODO comment in d81ef13 in #164. cc @agnostack.

[todo]

display config version here in UI -->

magento_extension/src/app/code/community/Zendesk/Zendesk/etc/system.xml

Lines 27 to 30 in d81ef13

	<!-- TODO: display config version here in UI -->
	<zendesk translate="label" module="zendesk">
	<label>Zendesk</label>
	<class>zendesk-section</class>

---

This comment was generated by todo based on a TODO comment in d81ef13 in #164. cc @agnostack.

[todo]

should this be customerId or entity id??

magento_extension/src/app/code/community/Zendesk/Zendesk/Helper/Data.php

Lines 459 to 464 in 3c9b180

	$id = $order->getCustomerId(); // TODO: should this be customerId or entity id??
	$email = $order->getCustomerEmail();
	$customer = array();
	if ($isGuest){
	$customer['type'] = 'guest';

---

This comment was generated by todo based on a TODO comment in 3c9b180 in #164. cc @agnostack.

[todo]

display config version here in UI -->

magento_extension/src/app/code/community/Zendesk/Zendesk/etc/system.xml

Lines 27 to 30 in 3c9b180

	<!-- TODO: display config version here in UI -->
	<zendesk translate="label" module="zendesk">
	<label>Zendesk</label>
	<class>zendesk-section</class>

---

This comment was generated by todo based on a TODO comment in 3c9b180 in #164. cc @agnostack.

[todo]

display config version here in UI -->

magento_extension/src/app/code/community/Zendesk/Zendesk/etc/system.xml

Lines 27 to 30 in 7270a84

	<!-- TODO: display config version here in UI -->
	<zendesk translate="label" module="zendesk">
	<label>Zendesk</label>
	<class>zendesk-section</class>

---

This comment was generated by todo based on a TODO comment in 7270a84 in #164. cc @agnostack.

[todo]

display config version here in UI -->

magento_extension/src/app/code/community/Zendesk/Zendesk/etc/system.xml

Lines 27 to 30 in fc937ec

	<!-- TODO: display config version here in UI -->
	<zendesk translate="label" module="zendesk">
	<label>Zendesk</label>
	<class>zendesk-section</class>

---

This comment was generated by todo based on a TODO comment in fc937ec in #164. cc @agnostack.

[todo]

display config version here in UI -->

magento_extension/src/app/code/community/Zendesk/Zendesk/etc/system.xml

Lines 27 to 30 in 8fa721a

	<!-- TODO: display config version here in UI -->
	<zendesk translate="label" module="zendesk">
	<label>Zendesk</label>
	<class>zendesk-section</class>

---

This comment was generated by todo based on a TODO comment in 8fa721a in #164. cc @agnostack.

[todo]

display config version here in UI -->

magento_extension/src/app/code/community/Zendesk/Zendesk/etc/system.xml

Lines 27 to 30 in 10247cd

	<!-- TODO: display config version here in UI -->
	<zendesk translate="label" module="zendesk">
	<label>Zendesk</label>
	<class>zendesk-section</class>

---

This comment was generated by todo based on a TODO comment in 10247cd in #164. cc @agnostack.

[todo]

display config version here in UI -->

magento_extension/src/app/code/community/Zendesk/Zendesk/etc/system.xml

Lines 27 to 30 in e80f306

	<!-- TODO: display config version here in UI -->
	<zendesk translate="label" module="zendesk">
	<label>Zendesk</label>
	<class>zendesk-section</class>

---

This comment was generated by todo based on a TODO comment in e80f306 in #164. cc @agnostack.

[todo]

display config version here in UI -->

magento_extension/src/app/code/community/Zendesk/Zendesk/etc/system.xml

Lines 27 to 30 in 89bacb6

	<!-- TODO: display config version here in UI -->
	<zendesk translate="label" module="zendesk">
	<label>Zendesk</label>
	<class>zendesk-section</class>

---

This comment was generated by todo based on a TODO comment in 89bacb6 in #164. cc @agnostack.

[todo]

display config version here in UI -->

magento_extension/src/app/code/community/Zendesk/Zendesk/etc/system.xml

Lines 27 to 30 in 047a2c8

	<!-- TODO: display config version here in UI -->
	<zendesk translate="label" module="zendesk">
	<label>Zendesk</label>
	<class>zendesk-section</class>

---

This comment was generated by todo based on a TODO comment in 047a2c8 in #164. cc @agnostack.

[driskell]

Hello - this should really be inside _authorise after the token is validated, to ensure the version is not exposed to unauthorised clients, as otherwise it could be used to detect vulnerable versions.