-
Notifications
You must be signed in to change notification settings - Fork 194
Release 3.0 #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Release 3.0 #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE that is part of the 3.x release
Drop CALL_API alias
Dispatch failure FSA when fetch fails
Thanks to @iamandrewluca Keep same signature Export createMiddleware Export defaults into separate file Explicit export createMiddleware Add local ok handler, take fetch from createMiddleware Now user can provide a global ok/fetch handler or a local ok/fetch handler Local ok/fetch handler will take priority
Add custom `ok` hander (#171) + cleanup, docs, and tests
…aa-props allow non-Symbol object properties on RSAA
the babel-istanbul setup was having problems parsing source, and nyc appears to "just work" Add a test
Microbundle
#199: only await if custom payload/meta is a function
Resolves #196 and h/t to @ranjeet-choudhary
Bundle updates
Add test case for descriptor with meta + payload functions
Migrate tests to jest
This is a follow-up to #175, which updated this behavior and docs for failed fetches, to include failures in RSAA custom methods, such as `[RSAA].headers`
Update handling of failure in RSAA descriptor custom methods
This reveals real-world issues better than testing against src, although I'm not sure if this is the best way to do it, or if there is value in running against both. Related to #199, fixing the failing tests here block the v3 release.
- Switch from microbundle to raw rollup (fixes #199) - Upgrade to babel v7 - Set up test suite to run against src/es or lib based on TEST_LIB env var
Run tests against lib
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the delay, folks! The last beta seems pretty solid -- I've know of a few places its being used in production, and I haven't seen any new issues pop up...so here we go!
Thank you to @iamandrewluca @darthrellimnad and @ztanner for contributing to this release, and everyone for using this middleware, reporting issues, and requesting features 🌴
A lot of changes in this release: https://github.com/agraboso/redux-api-middleware/milestone/3?closed=1