Skip to content

Conversation

nason
Copy link
Collaborator

@nason nason commented Nov 6, 2018

Sorry for the delay, folks! The last beta seems pretty solid -- I've know of a few places its being used in production, and I haven't seen any new issues pop up...so here we go!

Thank you to @iamandrewluca @darthrellimnad and @ztanner for contributing to this release, and everyone for using this middleware, reporting issues, and requesting features 🌴

A lot of changes in this release: https://github.com/agraboso/redux-api-middleware/milestone/3?closed=1

nason and others added 30 commits June 10, 2018 12:31
BREAKING CHANGE that is part of the 3.x release
Previously:

RSAA -> Request FSA -> Request Error FSA

Now:

RSAA -> Request FSA -> Failure FSA

Closes #26 #44 #99
Dispatch failure FSA when fetch fails
Thanks to @iamandrewluca

Keep same signature

Export createMiddleware

Export defaults into separate file

Explicit export createMiddleware

Add local ok handler, take fetch from createMiddleware

Now user can provide a global ok/fetch handler or a local ok/fetch handler
Local ok/fetch handler will take priority
Add custom `ok` hander (#171) + cleanup, docs, and tests
…aa-props

allow non-Symbol object properties on RSAA
the babel-istanbul setup was having problems parsing
source, and nyc appears to "just work"

Add a test
#199: only await if custom payload/meta is a function
Add test case for descriptor with meta + payload functions
nason and others added 12 commits July 15, 2018 00:29
This is a follow-up to #175, which updated this behavior and docs
for failed fetches, to include failures in RSAA custom methods,
such as `[RSAA].headers`
Update handling of failure in RSAA descriptor custom methods
This reveals real-world issues better than testing against src,
although I'm not sure if this is the best way to do it, or if
there is value in running against both.

Related to #199, fixing the failing tests here block the v3 release.
- Switch from microbundle to raw rollup (fixes #199)
- Upgrade to babel v7
- Set up test suite to run against src/es or lib based on TEST_LIB env var
@nason nason added this to the 3.0.0 milestone Nov 6, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3593b9e on next into 08e87ec on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3593b9e on next into 08e87ec on master.

@nason nason merged commit 526b5de into master Nov 6, 2018
@unrevised6419 unrevised6419 deleted the next branch March 18, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants