Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge with other repository #212

Merged
merged 7 commits into from
Dec 17, 2018
Merged

chore: merge with other repository #212

merged 7 commits into from
Dec 17, 2018

Conversation

steveoh
Copy link
Member

@steveoh steveoh commented Dec 5, 2018

This pr merges with steveoh/react-atlas.

  • Uses create react app with esri loader to boilerplate newer apps
  • It updates the issue templates to use the new labels feature and categories
  • Adds a new folder for forklift pallets
  • Changes the readmes to .gitkeep

There are a couple of regressions but we can work to add those back as a good exercise in practicing with this stack.

  • Make slightly more mobile friendly by hiding the sidebar (on load) and AGRC logo on smaller width devices.
  • Randomly choose from the capitols of the four most populous counties as the default extent on load.
  • Persist map extent between sessions (via local storage)
  • There are no tests. It would be great to learn that together
  • The components could be made more robust

oh and ps - this branch is in production... 🤠

pps - the dojo 4.x version was 9mb and this one is 1.5

@stdavis
Copy link
Member

stdavis commented Dec 7, 2018

This is awesome. I love it!!!

I'll open a PR against this branch with some of my tweaks and new features.

stdavis
stdavis previously approved these changes Dec 7, 2018
@stdavis
Copy link
Member

stdavis commented Dec 7, 2018

I'm guessing that you saw Rene's recent post: https://www.esri.com/arcgis-blog/products/js-api-arcgis/mapping/using-react-with-the-arcgis-api-for-javascript/

Oh how I would like to be able to import map from 'esri/Map' but I'm not sure that it's worth ejecting for. I still have hopes that Esri is getting closer to being done with AMD thus allowing us to use their api without any hacks.

@stdavis
Copy link
Member

stdavis commented Dec 17, 2018

There are the only three issues that I can see left on this thread:

  • Persist map extent between sessions (via local storage)
  • There are no tests. It would be great to learn that together
  • The components could be made more robust
  • Consider using hooks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants