Replace extract-image-names.sh with JS script #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhollas
force-pushed
the
update-bake-action
branch
from
5f6d697 to
7581010
Compare
danielhollas
commented
Feb 4, 2025
| # rsync: needed to support the new AiiDA backup command | ||
| # povray: rendering engine used in aiidalab-widgets-base | ||
| # bc: needed to compute the resources for computer setup | ||
| ENV EXTRA_APT_PACKAGES "curl povray rsync build-essential bc" |
There was a problem hiding this comment.
This is just unrelated cleanup to get rid of Docker deprecation warnings.
danielhollas
commented
Feb 13, 2025
danielhollas
force-pushed
the
update-bake-action
branch
from
6976023 to
2867e65
Compare
|
I am going to go ahead and merge this since it is a clear improvement over the previous solution. Happy to take a post-merge review as a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extract-image-names.shis one of the uglier parts of our Docker build CI workflow,in which we use an inscrutable
jqscript to parse a JSON string that holds metadata output from bake-action.Here we substitute it with hopefully more readable javascript, as proposed in docker/bake-action#239 (comment)
Unfortunately does not fully solve #493, see my comment in the upstream issue for details:
docker/bake-action#239 (comment)
See also corresponding aiida-core issue aiidateam/aiida-core#6582. I'll submit a PR there as well once this is merged.