Repository navigation
Run pyrefly alongside mypy
#13558
Closed
MarcoGorelli
started this conversation in
General
Replies: 2 comments
|
I don't really want to maintain multiple type checkers on our repos and I expect these extra checks will make their way into mypy eventually. But, the typing changes look correct, so feel free to open a PR for those. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
I was taking a look at whether
pyreflywould work on theaiohttpcodebase (https://github.com/aio-libs/aiohttp/compare/master...MarcoGorelli:pyrefly?expand=1), and found that it works wellIt flags a couple of issues where aiohttp is relying on behaviour which goes against the typing spec but which mypy happens to accept (using the same
TypeVarin both the__init__and the class, and usingUnpackwith aTypedDictoutside of**kwargs), so I think these would be valuable to fix anyway, both to future-proof against future versions of mypy which may fix these, and in case you wanted to migrate to a different type-checker anyway. See python/typeshed#11780 for a discussion in Typeshed where they ran into the first issue when upgrading PyrightIf you're interested in this, I'm happy to open the PR (in which the issues are already fixed)
All reactions