Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the third example of the POST multipart encoded file of the documentation #274

Merged
merged 2 commits into from
Feb 16, 2015

Conversation

arthurdarcet
Copy link
Contributor

If i'm not mistaken, the third example given in the documentation (here)[http://aiohttp.readthedocs.org/en/v0.14.4/client.html#post-a-multipart-encoded-file] is not implemented:

>>> url = 'http://httpbin.org/post'
>>> files = {'file': ('report.csv',
...                   'some,data,to,send\nanother,row,to,send\n')
... }

>>> yield from aiohttp.request('post', url, data=files)

would post nothing

@asvetlov
Copy link
Member

-1
The code for example was intentionally removed. I guess to remove example from docs also.
New multipart support should be build on top of #273

…he documentation

If i'm not mistaken, the third example given in the documentation (here)[http://aiohttp.readthedocs.org/en/v0.14.4/client.html#post-a-multipart-encoded-file] does not work:

```
>>> url = 'http://httpbin.org/post'
>>> files = {'file': ('report.csv',
...                   'some,data,to,send\nanother,row,to,send\n')
... }

>>> yield from aiohttp.request('post', url, data=files)
```
would post nothing
@arthurdarcet
Copy link
Contributor Author

Ok, updated the commit to edit the docs instead. It's kind of misleading as-is…

@asvetlov
Copy link
Member

Please fix pep8 errors (run "$ make test" command before pushing changes)

@arthurdarcet
Copy link
Contributor Author

The pep8 error is unrelated to this commit ; I've fixed it none the less

asvetlov added a commit that referenced this pull request Feb 16, 2015
Implement the third example of the `POST multipart encoded file` of the documentation
@asvetlov asvetlov merged commit 5db7258 into aio-libs:master Feb 16, 2015
@asvetlov
Copy link
Member

Thanks!

@arthurdarcet arthurdarcet deleted the patch-1 branch October 27, 2016 08:42
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants