-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Allows the use of VERTICAL_SCROLLABLE constant in DateRangePicker com… #1353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Sorry for the delay. This is a great bug fix, but it needs a regression test, can you add one? |
|
@ljharb sorry closed this thinking it was no longer needed. Yeah I can add a test. |
|
@ljharb Could you take another look? |
ljharb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending a rebase
|
@ljharb done 🙂 |
|
@theolampert I've rebased this; could we add some storybook stories that cover this new orientation? |
Codecov Report
@@ Coverage Diff @@
## master #1353 +/- ##
==========================================
+ Coverage 80.02% 80.19% +0.16%
==========================================
Files 57 57
Lines 2303 2292 -11
Branches 636 636
==========================================
- Hits 1843 1838 -5
+ Misses 271 267 -4
+ Partials 189 187 -2
Continue to review full report at Codecov.
|
|
@ljharb I wasn't able to get storybook to build on an M1 mac, complains about node-sass missing so I assume it's some native module thing I didn't really want to debug. I'll try and take a look from an intel machine either tonight or tomorrow. |
|
@theolampert node-sass requires very specific node versions - in this case, i think node 14? and on an M1 mac, node < 16 requires installing it via rosetta. |
I'm unsure if this is actually wanted or not but there seems to be a few others wanting to use
DateRangePickercomponent with vertical scrolling.Currently it works fine but results in an ugly proptype warning. This PR attempts to address that by importing
ScrollableOrientationShaperather thanOrientationShapewithinDateRangePickerShape