Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows the use of VERTICAL_SCROLLABLE constant in DateRangePicker com… #1353

Open
wants to merge 1 commit into
base: master
from

Conversation

@theolampert
Copy link

theolampert commented Sep 12, 2018

I'm unsure if this is actually wanted or not but there seems to be a few others wanting to use DateRangePicker component with vertical scrolling.

Currently it works fine but results in an ugly proptype warning. This PR attempts to address that by importing ScrollableOrientationShape rather than OrientationShape within DateRangePickerShape

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 12, 2018

Coverage Status

Coverage remained the same at 84.875% when pulling 8e640c2 on theolampert:master into 0e019f5 on airbnb:master.

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Dec 12, 2019

Sorry for the delay. This is a great bug fix, but it needs a regression test, can you add one?

@theolampert

This comment has been minimized.

Copy link
Author

theolampert commented Dec 12, 2019

@ljharb sorry closed this thinking it was no longer needed. Yeah I can add a test.

@theolampert

This comment has been minimized.

Copy link
Author

theolampert commented Dec 30, 2019

@ljharb Could you take another look?

@ljharb
ljharb approved these changes Jan 1, 2020
Copy link
Collaborator

ljharb left a comment

LGTM pending a rebase

@theolampert theolampert force-pushed the theolampert:master branch from b45ef1c to 9dc9048 Jan 2, 2020
@theolampert

This comment has been minimized.

Copy link
Author

theolampert commented Jan 2, 2020

@ljharb done 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.