[Fix] DateRangePickerInput: customArrowIcon always overrides RTL or small icon
#1508
Conversation
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Could you provide tests for this?
|
Hi @ljharb, I'll try to free up some time and add a test for this one :) |
|
Hey looks like this one was abandoned? It would be great if we could get going again or open a new up to date PR as it also addresses this issue. |
|
Hi @americool, not abandoned, I'll get to it probably next week :) |
|
@ljharb @americool |
|
Please don’t open duplicate PRs; now i have to keep both in sync. |
|
Sorry @ljharb I've closed this one just to keep the order since I've created a new branch in my fork.. The new PR contains everything from this PR. |
|
I'm not sure what "keep the order" means. |
I just didn't want to push from master so I've created a new pr from a different branch. Sorry for the trouble. |
…abel/runtime`, `@storybook/addon-actions`, `@storybook/addon-info`, `@storybook/addon-links`, `@storybook/addon-options`, `@storybook/addons`, `@storybook/react`, `@welldone-software/why-did-you-render`, `airbnb-js-shim`, `aphrodite`, `babel-eslint`, `babel-loader`, `babel-plugin-inline-react-svg`, `babel-plugin-inline-svg`, `babel-preset-airbnb`, `clean-css`, `coveralls`, `cross-env`, `enzyme`, `enzyme-adapter-react-helper`, `eslint`, `eslint-config-airbnb`, `eslint-plugin-import`, `eslint-plugin-jsx-a11y`, `eslint-plugin-react`, `eslint-plugin-react-hooks`, `eslint-plugin-react-with-styles`, `in-publish`, `react-with-styles-interface-aphrodite`, `rimraf`, `safe-publish-latest`, `sass-loader`, `sinon`, `sinon-sandbox`, `webpack`
…or small icon Fixes react-dates#1507. Fixes react-dates#1537.
ljharb
changed the title
DateRangePickerInput: customArrowIcon always overrides RTL or small icon
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I'm facing this issue again, customArrowIcon is overridden when isRTL is set to true |
6 participants
This PR is to enable customArrowIcon when using the calendar in RTL view.
If there is a customArrowIcon it will override the other arrows (small or RTL default arrow).
Fixes #1507 and #1537.