-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[New] {DateRangePicker,SingleDatePicker}{,Input,InputController}: add title text props
#1862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…dd title text props Fixes react-dates#1861.
|
@majapw and @caseklim Sure you guys are super busy, but I wanted to surface this again as it has already been reviewed by @backwardok and @ljharb and just requires both of your approvals to be mergeable. Please let me know if there's anything I'm missing here, will be happy to make any updates that may be needed to get this merged. Thanks :) |
|
Hey @nkinser ! Do you think you could do a review of this and approve if it looks good? |
|
@nkinser would love to get this approved/updated if it has any problems, when you get a chance! Really looking forward to using this functionality in our implementation :) |
|
@nkinser @backwardok is there anything I can do to help get this ready to be merged? I have full Storybook Documentation and Tests included in this PR :) I've also just pulled master into it and it looks like the tests are still passing (and after over 9 months! lucky me :)) Thank you for your time, I am sure you are extremely busy <3 |
|
Sorry for the delay - went on vacation last week! I think we should be ok to move forward. @ljharb do you want to merge this? |
{DateRangePicker,SingleDatePicker}{,Input,InputController}: add title text props
8371242 to
2b8089b
Compare
|
@ljharb, it seems this feature was not released |
|
@farideliyev correct, there hasn't been a release in awhile. it will be included in the next release, which has no planned date but will hopefully be soon. |
This PR was created to solve #1861 & it has Full Storybook Documentation & Tests
This enables react-dates users to add
titleattributes to the Start/End date fields, as well as the Single Date Picker date field.