Skip to content

Conversation

@vastolf
Copy link
Contributor

@vastolf vastolf commented Nov 13, 2019

This PR was created to solve #1861 & it has Full Storybook Documentation & Tests

This enables react-dates users to add title attributes to the Start/End date fields, as well as the Single Date Picker date field.

@ljharb ljharb added accessibility Anything related to ensuring *everybody* can use react-dates <3 semver-minor: new stuff Any feature or API addition. labels Nov 13, 2019
@vastolf
Copy link
Contributor Author

vastolf commented Dec 10, 2019

@majapw and @caseklim Sure you guys are super busy, but I wanted to surface this again as it has already been reviewed by @backwardok and @ljharb and just requires both of your approvals to be mergeable.

Please let me know if there's anything I'm missing here, will be happy to make any updates that may be needed to get this merged. Thanks :)

@vastolf
Copy link
Contributor Author

vastolf commented Feb 25, 2020

@majapw and @caseklim hoping to get this reviewed if possible! Can imagine you're very busy but wanted to surface this again as it's been a couple months

@backwardok backwardok requested review from nkinser and removed request for caseklim and majapw February 26, 2020 00:43
@backwardok
Copy link
Contributor

Hey @nkinser ! Do you think you could do a review of this and approve if it looks good?

@vastolf
Copy link
Contributor Author

vastolf commented Mar 20, 2020

@nkinser would love to get this approved/updated if it has any problems, when you get a chance! Really looking forward to using this functionality in our implementation :)

@vastolf
Copy link
Contributor Author

vastolf commented Aug 7, 2020

@nkinser @backwardok is there anything I can do to help get this ready to be merged? I have full Storybook Documentation and Tests included in this PR :) I've also just pulled master into it and it looks like the tests are still passing (and after over 9 months! lucky me :))

Thank you for your time, I am sure you are extremely busy <3

@backwardok
Copy link
Contributor

Sorry for the delay - went on vacation last week! I think we should be ok to move forward. @ljharb do you want to merge this?

@ljharb ljharb changed the title 1861: Adding ability to set the title attribute on datepicker inputs [New] {DateRangePicker,SingleDatePicker}{,Input,InputController}: add title text props Aug 18, 2020
@ljharb ljharb force-pushed the 1861-title-attributes branch from 8371242 to 2b8089b Compare August 18, 2020 05:59
@ljharb ljharb merged commit 2b8089b into react-dates:master Aug 18, 2020
@farideliyev
Copy link

@ljharb, it seems this feature was not released

@ljharb
Copy link
Member

ljharb commented Jul 6, 2022

@farideliyev correct, there hasn't been a release in awhile. it will be included in the next release, which has no planned date but will hopefully be soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility Anything related to ensuring *everybody* can use react-dates <3 semver-minor: new stuff Any feature or API addition.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants