Fix SingleDatePicker when appendToBody is enabled. #1890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilbsgilbs
force-pushed
the
fix-appendtobody-singledatepicker
branch
from
2583f44 to
c0f332d
Compare
Author
|
By the way, a less controversial fix might be what I suggested here about a year ago. |
|
This is happening in my project as well |
ljharb
force-pushed
the
fix-appendtobody-singledatepicker
branch
from
c0f332d to
e34fc2f
Compare
ljharb
requested changes
Dec 1, 2021
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
I am very concerned about removing what the comment implies is a workaround for IE < 11, or other older browsers.
Codecov Report
@@ Coverage Diff @@
## master #1890 +/- ##
==========================================
+ Coverage 79.99% 80.06% +0.06%
==========================================
Files 57 57
Lines 2299 2297 -2
Branches 638 636 -2
==========================================
Hits 1839 1839
+ Misses 271 269 -2
Partials 189 189
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1550
Disclaimer: this fix is probably very naive and I make it for the sole purpose of bringing attention of contributors and maintainers on this bug that has been around for way too long now. Given that neither of:
are of any help at understanding why
relatedTargetwas looked for in the first place, and given that it introduces a bug in theappendToBody={true}case, this is the most logical PR I could come up with.