Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onClose method for DRP #1893

Open
wants to merge 5 commits into
base: master
from
Open

Conversation

@mmarkelov
Copy link
Contributor

mmarkelov commented Jan 9, 2020

#1892
I suppose following issue because of firing onClearFocus with start and end dates from props, that's not right it should use values inside onEndDateChange function

Copy link
Collaborator

ljharb left a comment

Thanks, could you add a regression test?

Copy link
Collaborator

ljharb left a comment

LGTM pending improving the failure message on a few test assertions

@ljharb
ljharb approved these changes Jan 11, 2020
mmarkelov added 2 commits Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.