Skip to content

Conversation

@mmarkelov
Copy link
Contributor

@mmarkelov mmarkelov commented Jan 9, 2020

Fixes #1892
I suppose following issue because of firing onClearFocus with start and end dates from props, that's not right it should use values inside onEndDateChange function

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could you add a regression test?

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending improving the failure message on a few test assertions

@tjhart
Copy link

tjhart commented Mar 7, 2020

If I understand correctly, these changes will fix #1892 ? It's causing issues for me as well. What's left to get a release out that includes this?

@tjhart
Copy link

tjhart commented Mar 20, 2020

@ljharb Leaving another ping about this. I see that the changes have been approved, and I haven't found that another issue superseding this one. Can I do anything to help get this into a release?

@ljharb ljharb force-pushed the Fix-onClose-method branch from 3e43d5f to ba61165 Compare November 30, 2021 22:17
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #1893 (ba61165) into master (17c3c88) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1893      +/-   ##
==========================================
+ Coverage   80.00%   80.02%   +0.01%     
==========================================
  Files          57       57              
  Lines        2296     2298       +2     
  Branches      637      637              
==========================================
+ Hits         1837     1839       +2     
  Misses        271      271              
  Partials      188      188              
Impacted Files Coverage Δ
src/components/DateRangePickerInputController.jsx 95.08% <66.66%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17c3c88...ba61165. Read the comment docs.

@ljharb ljharb changed the title Fix onClose method for DRP [Fix] DateRangePickerInputController: fix onClose method Nov 30, 2021
@ljharb ljharb merged commit ba61165 into react-dates:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

onClose returns incorrect endDate if it's been entered manually in the input

3 participants