-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[Fix] DateRangePickerInputController: fix onClose method
#1893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ljharb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, could you add a regression test?
ljharb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending improving the failure message on a few test assertions
|
If I understand correctly, these changes will fix #1892 ? It's causing issues for me as well. What's left to get a release out that includes this? |
|
@ljharb Leaving another ping about this. I see that the changes have been approved, and I haven't found that another issue superseding this one. Can I do anything to help get this into a release? |
3e43d5f to
ba61165
Compare
Codecov Report
@@ Coverage Diff @@
## master #1893 +/- ##
==========================================
+ Coverage 80.00% 80.02% +0.01%
==========================================
Files 57 57
Lines 2296 2298 +2
Branches 637 637
==========================================
+ Hits 1837 1839 +2
Misses 271 271
Partials 188 188
Continue to review full report at Codecov.
|
DateRangePickerInputController: fix onClose method
Fixes #1892
I suppose following issue because of firing onClearFocus with start and end dates from props, that's not right it should use values inside onEndDateChange function