[Fix] getVisibleDays #1929
Draft
[Fix] getVisibleDays #1929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
09sh-iwata
force-pushed
the
fix_outside_range_modifiers
branch
from
595aec5 to
935e09e
Compare
ljharb
requested changes
Nov 30, 2021
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
This looks great! Can we also add tests for the two components that are changed?
Author
|
@ljharb |
Member
|
@d1ckeys yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #698
Pass firstDayOfWeek to getVisibleDays