[New] DayPickerSingleDateController: add allowUnselect prop option to allow unselecting dates
#2066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allows controlling whether unselecting selected days is possible
ljharb
force-pushed
the
feature/unselect-date
branch
from
0f3ccea to
6c2cb61
Compare
ljharb
changed the title
DayPickerSingleDateController: add allowUnselect prop option to allow unselecting dates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new property in DayPickerSingleDateController which allows users to unselect a previously selected date by clicking on it.
This PR fixes #2061.
I'm tentatively increasing the minor version given that this PR effectively adds new functionality in a backward compatible way. I'm happy to simply increase the patch version as well, even though this is not necessarily a bug fix.
Alternative considered in the implementation:
I've also considered making this functionality enabled by default, however there would be the risk that it would break users who would not handle undefined (or eventually null) in the onDateChange callback.