write tests for the base_images package #30661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
This was referenced Sep 21, 2023
alafanechere
force-pushed
the
augustin/declare-first-base-image
branch
from
1de4960
to
1533e75
Compare
alafanechere
force-pushed
the
augustin/09-21-write_tests_for_the_base_images_package
branch
from
95405c7
to
ef228a7
Compare
bnchrch
reviewed
Sep 21, 2023
| @@ -32,3 +32,15 @@ jobs: | |||
| sentry_dsn: ${{ secrets.SENTRY_AIRBYTE_CI_DSN }} | |||
| github_token: ${{ secrets.GH_PAT_MAINTENANCE_OCTAVIA }} | |||
| subcommand: "test airbyte-ci/connectors/pipelines" | |||
| - name: Run airbyte-ci/connectors/base_images tests | |||
bnchrch
approved these changes
Sep 21, 2023
alafanechere
merged commit 1557e0e
into
augustin/declare-first-base-image
25 of 26 checks passed
alafanechere
deleted the
augustin/09-21-write_tests_for_the_base_images_package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add tests on top of the
base_imagespackages.Reaching 57% coverage.
Auto run it in the CI