Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad calls to conversations.info when opening inbox #1768

Closed
chrismatix opened this issue May 10, 2021 · 1 comment · Fixed by #1775
Closed

Bad calls to conversations.info when opening inbox #1768

chrismatix opened this issue May 10, 2021 · 1 comment · Fixed by #1775
Assignees
@AudreyKj
Labels
bug inbox

Comments

@chrismatix
Copy link
Contributor

Problem

When opening the inbox, the current conversation is being requested with /conversations.info but the request payload is empty which results in a loop of 400 Bad Request calls.

This does not impact the app behavior.

image

Expected behavior
The endpoint is called with a conversation id when needed.
@AudreyKj AudreyKj self-assigned this May 11, 2021
@AudreyKj
Copy link
Contributor

this happens when there are no conversations in the inbox

@AudreyKj AudreyKj mentioned this issue May 11, 2021
Merged
AudreyKj added a commit that referenced this issue May 17, 2021
@AudreyKj
[#1768] bad calls to conversations info when opening inbox (#1775)
35e617a 
* fixed bad calls to conversation info when opening inbox

* added error code

* removed test

* removed 404 check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AudreyKj AudreyKj

Labels
bug inbox
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1768] bad calls to conversations info when opening inbox airyhq/airy
2 participants
@chrismatix @AudreyKj