[#1768] bad calls to conversations info when opening inbox #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudreyKj
commented
May 11, 2021
| .catch(async (error: Error) => { | ||
| if (retries > 5) { | ||
| .catch(async (error: ConversationInfoError) => { | ||
| if (retries > 5 || error.status === 404) { | ||
| return Promise.reject(error); | ||
| } else { |
There was a problem hiding this comment.
if the conversation Id is not found, we return and do not fetch again to avoid loops
There was a problem hiding this comment.
The loop is necessary to find the conversation when we get a websocket notification. If we remove this loop we won't be able to display conversations that come from ws because sometimes some metadata updates arrive even before the actual conversation.
AudreyKj
commented
May 11, 2021
| export interface ConversationInfoError extends Error { | ||
| status: number; | ||
| body?: any; | ||
| } |
There was a problem hiding this comment.
Created a custom Error type to check the error's status
AudreyKj
commented
May 12, 2021
| getConversationInfo(match.params.conversationId); | ||
| } | ||
| }, [conversations]); | ||
| }, [currentConversation, match.params.conversationId]); | ||
|
|
||
| const hideSuggestedReplies = () => { |
There was a problem hiding this comment.
there was a 404 loop when opening inbox because the endpoint was called even if there was no conversation ID
lucapette
approved these changes
May 12, 2021
AudreyKj
deleted the
fix/1768-bad-calls-to-conversations-info-when-opening-inbox
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1768