Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1773] Filter conversations by source #1864

Merged
merged 3 commits into from
May 31, 2021

Conversation

chrismatix
Copy link
Contributor

resolves #1773

@@ -1,10 +0,0 @@
export interface ConversationFilter {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not belong in the model library since it's a UI model

@chrismatix chrismatix requested review from stayprodio, lucapette, ljupcovangelski and pascal-holy and removed request for stayprodio May 31, 2021 07:39
Copy link
Contributor

@pascal-holy pascal-holy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@stayprodio stayprodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! but we should think about the positioning of the pop up module of the filtering as it has now 1 more option. Might look a bit odd on a 13' display

@chrismatix chrismatix merged commit a88ce2e into develop May 31, 2021
@chrismatix chrismatix deleted the feat/1773-filter-conversations-by-source branch May 31, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inbox: Filter bySource option
3 participants