Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show all results for static ips list #285

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Show all results for static ips list #285

merged 1 commit into from
Apr 12, 2022

Conversation

dangquangdon
Copy link
Contributor

@dangquangdon dangquangdon commented Apr 7, 2022 •
edited
Loading

@dangquangdon dangquangdon requested a review from a team as a code owner April 7, 2022 09:06
@dangquangdon dangquangdon force-pushed the dangquangdon-dark-637-static-ip-cli-pagination branch from 06a28b8 to 666e43b Compare April 7, 2022 09:12
dmitrii-vasilev
dmitrii-vasilev previously requested changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@dmitrii-vasilev dmitrii-vasilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't implement our own paging support

aiven/client/cli.py Outdated Show resolved Hide resolved
@dangquangdon dangquangdon force-pushed the dangquangdon-dark-637-static-ip-cli-pagination branch from 666e43b to 1aebd64 Compare April 12, 2022 14:38
@dangquangdon dangquangdon changed the title Support pagination for static ips list Show all results for static ips list Apr 12, 2022
Show all static ips
ec61341 
[DARK-637]
@dangquangdon dangquangdon force-pushed the dangquangdon-dark-637-static-ip-cli-pagination branch from 1aebd64 to ec61341 Compare April 12, 2022 14:43
dmitrii-vasilev
dmitrii-vasilev approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@dmitrii-vasilev dmitrii-vasilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitrii-vasilev dmitrii-vasilev merged commit 60664f6 into main Apr 12, 2022
@dmitrii-vasilev dmitrii-vasilev deleted the dangquangdon-dark-637-static-ip-cli-pagination branch April 12, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrii-vasilev dmitrii-vasilev dmitrii-vasilev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dangquangdon @dmitrii-vasilev