Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(universal): update dependencies to support universal environment #2057

Merged
merged 8 commits into from
Nov 20, 2019

Conversation

denStrigo
Copy link
Collaborator

@denStrigo denStrigo commented Oct 31, 2019

Update intersection-observer, eva-icons packages. Add ssr in package-smoke for check.

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Fixes #2008.
Updates @nebuarl/theme deps to work in Universal environment (intersection-observer, eva-icons).
Adds Angular Universal smoke test.

@codecov
Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #2057 into master will decrease coverage by 0.01%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##           master    #2057      +/-   ##
==========================================
- Coverage   84.59%   84.57%   -0.02%     
==========================================
  Files         235      235              
  Lines        8055     8059       +4     
  Branches      709      710       +1     
==========================================
+ Hits         6814     6816       +2     
- Misses       1022     1023       +1     
- Partials      219      220       +1
Impacted Files Coverage Δ
...onents/tree-grid/tree-grid-row-toggle.component.ts 54.54% <100%> (ø) ⬆️
...mework/theme/components/button/button.component.ts 87.77% <100%> (ø) ⬆️
...onents/tree-grid/tree-grid-row-toggle.directive.ts 62.5% <100%> (ø) ⬆️
...mework/theme/components/select/option.component.ts 98.18% <100%> (ø) ⬆️
src/framework/theme/theme.module.ts 82.6% <66.66%> (-7.87%) ⬇️
.../framework/theme/components/menu/menu.component.ts 76.8% <66.66%> (+0.37%) ⬆️

@denStrigo denStrigo force-pushed the fix/fix-ssr branch 3 times, most recently from e7fd9e0 to b91e5ce Compare November 1, 2019 14:43
…, eva-icons packages. Add ssr in package-smoke for check
@yggg yggg changed the title fix(ssr): fix angular universal support. fix(universal): update dependencies to support universal environment Nov 20, 2019
@yggg yggg merged commit 0b22c40 into akveo:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NG Universal app failed to start
2 participants