-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(universal): update dependencies to support universal environment #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denStrigo
force-pushed
the
fix/fix-ssr
branch
from
October 31, 2019 14:34
15d262a
to
5ed41c0
Compare
Codecov Report
@@ Coverage Diff @@
## master #2057 +/- ##
==========================================
- Coverage 84.59% 84.57% -0.02%
==========================================
Files 235 235
Lines 8055 8059 +4
Branches 709 710 +1
==========================================
+ Hits 6814 6816 +2
- Misses 1022 1023 +1
- Partials 219 220 +1
|
denStrigo
force-pushed
the
fix/fix-ssr
branch
3 times, most recently
from
November 1, 2019 14:43
e7fd9e0
to
b91e5ce
Compare
…, eva-icons packages. Add ssr in package-smoke for check
denStrigo
force-pushed
the
fix/fix-ssr
branch
from
November 7, 2019 15:37
b91e5ce
to
bc57cfe
Compare
Goes into separate PR to not introduce breaking changes and include into upcoming release.
yggg
approved these changes
Nov 20, 2019
yggg
changed the title
fix(ssr): fix angular universal support.
fix(universal): update dependencies to support universal environment
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update intersection-observer, eva-icons packages. Add ssr in package-smoke for check.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Fixes #2008.
Updates @nebuarl/theme deps to work in Universal environment (intersection-observer, eva-icons).
Adds Angular Universal smoke test.