Minor Fix for Token Transfer Tx #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lbqds
reviewed
Dec 17, 2024
| "destinations": [ | ||
| { | ||
| "address": "1C2RAVWSuaXw8xtUxqVERR7ChKBE1XgscNFw73NSHE1v3", | ||
| "attoAlphAmount": "10000000000000000", |
There was a problem hiding this comment.
It seems that it is not necessary because if the attoAlphAmount is not specified, the full node will calculate the required dust amount based on the token: https://github.com/alephium/alephium/blob/30c59df012625a3b568a455800cf025683237da2/app/src/main/scala/org/alephium/app/ServerUtils.scala#L914
There was a problem hiding this comment.
Seems that attoAlphAmount is required from the API, i will update the endpoint.
curl -X 'POST' \
'https://node.mainnet.alephium.org/transactions/build' \
-H 'accept: application/json' \
-H 'Content-Type: application/json' \
-d '{"fromPublicKey": "034e30eb5dd78000bcbe276e1202d0dc5499398321cc160cc8b10f2a71ffdfe7ca", "destinations": [{"address": "1C2RAVWSuaXw8xtUxqVERR7ChKBE1XgscNFw73NSHE1v3", "tokens":[{"id": "66da610efb5129c062e88
e5fd65fe810f31efd1597021b2edf887a4360fa0800", "amount": "1"}]}]}'
{"detail":"Invalid value for: body (missing keys in dictionary: attoAlphAmount at index 266: decoding failure)"}%There was a problem hiding this comment.
I didn't realize this, thanks for the fix!
Lbqds
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.