Skip to content

Update Oracles.md #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update Oracles.md #487

wants to merge 1 commit into from

Conversation

xbabyx
Copy link
Collaborator

@xbabyx xbabyx commented Mar 6, 2025

  • Added DIA Randomness Oracle
  • Table rendering for Prices Oracle group 0 addresses.

- Added DIA Randomness Oracle
- Table rendering for Prices Oracle group 0 addresses.
@polarker polarker requested a review from h0ngcha0 March 6, 2025 20:34
@polarker
Copy link
Member

polarker commented Mar 6, 2025

@h0ngcha0 Please help use review, thanks!


Below is the **DIARandomOracle** contract implementation in Ralph:

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use rust colorization here.

}
```


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Nit] Extra space

Below is the **DIARandomOracle** contract implementation in Ralph:

```
Contract DIARandomOracle(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the implementation of the DIARandomOracle. For developers to use it in the smart contract and fetch the randomness, do you think example like this is more useful?

@h0ngcha0
Copy link
Member

h0ngcha0 commented Mar 7, 2025

Will close this PR because the change is moved here (#488)

@h0ngcha0 h0ngcha0 closed this Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants