Cannot destructure property 'url' of 'nestedModules.pop(...)' as it is undefined. #218

bergercookie · 2021-03-28T09:21:17Z

I have a file called user.ts under the api/ directory with the following contents:

import type { APIRequest } from "https://deno.land/x/aleph/types.ts";

export default function handler(req: APIRequest) {
  console.log(`req: `, req);
  console.log(`req.params: `, req.params);
  console.log(`req.params.action: `, req.params.action);
  req.status(200).json({ name: req.params.action});
}

I'm making an HTTP GET request to it using httpie

➜ http -v  localhost:8080/api/user action==all
GET /api/user?action=all HTTP/1.1 <--------------- Actual GET Request
Accept: */*
Accept-Encoding: gzip, deflate
Connection: keep-alive
Host: localhost:8080
User-Agent: HTTPie/0.9.8



HTTP/1.1 500 Internal Server Error
cache-control: max-age=0
content-length: 209
content-type: text/html; charset=utf-8
date: Sun, 28 Mar 2021 09:05:39 GMT
server: Aleph.js

<!DOCTYPE html><title>500 - internal server error</title><p><strong><code>500</code></strong><small> - </small><span>Cannot destructure property 'url' of 'nestedModules.pop(...)' as it is undefined.</span></p>

Meanwhile, I can avoid getting a 500 error, only If I put this file under api/user/[name].ts, but in this case, it bundles the last part of the url along with the parameters after ?.

➜ http -v  localhost:8080/api/user/1 action==all

GET /api/user/1?action=all HTTP/1.1
Accept: */*
Accept-Encoding: gzip, deflate
Connection: keep-alive
Host: localhost:8080
User-Agent: HTTPie/0.9.8

HTTP/1.1 200 OK
content-length: 11
content-type: application/json; charset=utf-8
date: Sun, 28 Mar 2021 09:17:26 GMT
server: Aleph.js

{
    "name": {}
}


# Server output:
DEBUG compile '/api/user/[name].ts' in 1ms
req:  Request {}
req.params:  { name: "1action=all" }
req.params.action:  undefined

I suppose this isn't the expected behavior. Is this a bug? Am I doing something wrong?

The text was updated successfully, but these errors were encountered:

ije · 2021-03-28T10:57:28Z

this error means your api endpoint doesn't exist, i already fixed it.

bergercookie · 2021-03-28T11:03:08Z

But my endpoint does exist since I've put a file under /api/user.ts and I'm making a request like the following: /api/user?action=all

i already fixed it.

Is it fixed? The error still persist after aleph upgrade:

14:01:20 ➜ aleph --version
aleph.js 0.3.0-alpha.20
deno 1.8.1+2f9d7c0
v8 9.0.257.3
typescript 4.2.2

EDIT: Oh, just saw the latest commit, let me re-test it.

ije · 2021-03-28T11:06:33Z

oh, sorry! seems the api routing doesn't match the search ?action=all, i will fix it asap, thanks!

ije · 2021-03-28T11:07:05Z

try /api/user/[action].ts instead

bergercookie · 2021-03-28T11:17:00Z

try /api/user/[action].ts instead

Now, having renamed my file from user/[name].ts to user/[action.ts] when I make an HTTP request (GET /api/user/1?action=all) it still doesn't parse the parameters correctly:

INFO Server ready on http://localhost:8080/
req:  Request {}
req.params:  { action: "1action=all" }
req.params.action:  1action=all

Regarding the request GET /api/user?action=all I'm now getting an 404 instead of a 500 error like previously. But still, that's not the expected behavior. I would expect that this request would have been served by the /api/user.ts (or /api/user/index.ts) file and have the action=all be part of the req.params object.

Thanks for the quick reply and support! :)

ije · 2021-03-28T12:54:50Z

fixed, pls upgrade to alpha.22, thanks

ije added a commit that referenced this issue Mar 28, 2021

fix: fix api 500 error (#218)

e1bf72c

ije added the ✘ bug Something isn't working label Mar 28, 2021

ije added a commit that referenced this issue Mar 28, 2021

fix: fix api routing (#218)

e5505ba

ije closed this as completed Aug 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cannot destructure property 'url' of 'nestedModules.pop(...)' as it is undefined. #218

Cannot destructure property 'url' of 'nestedModules.pop(...)' as it is undefined. #218

bergercookie commented Mar 28, 2021

ije commented Mar 28, 2021

bergercookie commented Mar 28, 2021 •

edited

Loading

ije commented Mar 28, 2021 •

edited

Loading

ije commented Mar 28, 2021

bergercookie commented Mar 28, 2021

ije commented Mar 28, 2021

Cannot destructure property 'url' of 'nestedModules.pop(...)' as it is undefined. #218

Cannot destructure property 'url' of 'nestedModules.pop(...)' as it is undefined. #218

Comments

bergercookie commented Mar 28, 2021

ije commented Mar 28, 2021

bergercookie commented Mar 28, 2021 • edited Loading

ije commented Mar 28, 2021 • edited Loading

ije commented Mar 28, 2021

bergercookie commented Mar 28, 2021

ije commented Mar 28, 2021

bergercookie commented Mar 28, 2021 •

edited

Loading

ije commented Mar 28, 2021 •

edited

Loading