fix(ci): use yarn workspace to process release #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
reviewed
Feb 18, 2022
Comment on lines
+6
to
8
| "createReleaseIssue": "yarn build && node dist/scripts/release/create-release-issue.js", | ||
| "processRelease": "yarn build && node dist/scripts/release/process-release.js", | ||
| "setHostsOptions": "yarn build && node dist/scripts/pre-gen/setHostsOptions.js" |
There was a problem hiding this comment.
Is this expected to have this path? Why isn't it dist/pre-gen or dist/release?
There was a problem hiding this comment.
Oh because we include the openapitools.json config so it builds from the root structure? 🤔
There was a problem hiding this comment.
Yeah I didn't like it, but I think it's because I'm importing files outside the root of this package scripts (release.config.js and openapitools.json)
|
@shortcuts oops merged 142 first 😆 |
shortcuts
pushed a commit
that referenced
this pull request
Apr 22, 2022
* fix(ci): call the correct script to process release * fix: fix type issue
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Changes included: