Skip to content

fix(ci): use yarn workspace to process release #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2022
Merged

fix(ci): use yarn workspace to process release #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27ec945
fix(ci): call the correct script to process release
eunjae-lee Feb 18, 2022
5ace6eb
fix: fix type issue
eunjae-lee Feb 18, 2022
6f43f28
Merge branch 'main' into fix/release
eunjae-lee Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/process-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
id: setup
uses: ./.github/actions/setup

- run: ./scripts/release/process-release.js
- run: yarn workspace scripts processRelease
env:
EVENT_NUMBER: ${{ github.event.issue.number }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"specs:fix": "eslint --ext=yml specs/ --fix",
"specs:lint": "eslint --ext=yml specs/$0",
"github-actions:lint": "eslint --ext=yml .github/",
"release": "yarn workspace scripts release"
"release": "yarn workspace scripts createReleaseIssue"
},
"devDependencies": {
"@openapitools/openapi-generator-cli": "2.4.26",
Expand Down
4 changes: 3 additions & 1 deletion scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,15 @@
"version": "1.0.0",
"scripts": {
"build": "tsc",
"release": "yarn build && node dist/scripts/release/create-release-issue.js",
"createReleaseIssue": "yarn build && node dist/scripts/release/create-release-issue.js",
"processRelease": "yarn build && node dist/scripts/release/process-release.js",
"setHostsOptions": "yarn build && node dist/scripts/pre-gen/setHostsOptions.js"
Comment on lines +6 to 8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this expected to have this path? Why isn't it dist/pre-gen or dist/release?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh because we include the openapitools.json config so it builds from the root structure? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I didn't like it, but I think it's because I'm importing files outside the root of this package scripts (release.config.js and openapitools.json)

https://stackoverflow.com/a/58941798

},
"devDependencies": {
"@octokit/rest": "18.12.0",
"@types/js-yaml": "4.0.5",
"@types/node": "16.11.11",
"@types/semver": "7.3.9",
"dotenv": "16.0.0",
"execa": "5.1.1",
"js-yaml": "4.1.0",
Expand Down
2 changes: 1 addition & 1 deletion scripts/release/create-release-issue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ dotenv.config();
type Version = {
current: string;
langName: string;
next?: string;
next?: string | null;
noCommit?: boolean;
skipRelease?: boolean;
};
Expand Down
8 changes: 8 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1436,6 +1436,13 @@ __metadata:
languageName: node
linkType: hard

"@types/semver@npm:7.3.9":
version: 7.3.9
resolution: "@types/semver@npm:7.3.9"
checksum: 60bfcfdfa7f937be2c6f4b37ddb6714fb0f27b05fe4cbdfdd596a97d35ed95d13ee410efdd88e72a66449d0384220bf20055ab7d6b5df10de4990fbd20e5cbe0
languageName: node
linkType: hard

"@types/stack-utils@npm:^2.0.0":
version: 2.0.1
resolution: "@types/stack-utils@npm:2.0.1"
Expand Down Expand Up @@ -5885,6 +5892,7 @@ __metadata:
"@octokit/rest": 18.12.0
"@types/js-yaml": 4.0.5
"@types/node": 16.11.11
"@types/semver": 7.3.9
dotenv: 16.0.0
execa: 5.1.1
js-yaml: 4.1.0
Expand Down