Skip to content

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented May 23, 2022

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

  • Remove generated commits from the release issue
  • Bump versions that have not been bumped during release
  • Run yarn install after generating version bump to update the lock file

🧪 Test

CI :D

@shortcuts shortcuts requested review from eunjae-lee and millotp May 23, 2022 15:17
@shortcuts shortcuts self-assigned this May 23, 2022
@shortcuts shortcuts enabled auto-merge (squash) May 23, 2022 15:17
@netlify
Copy link

netlify bot commented May 23, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 3065d6e
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/628c8402e6174400082556da

@algolia-bot
Copy link
Collaborator

algolia-bot commented May 23, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts disabled auto-merge May 23, 2022 15:38
@shortcuts shortcuts marked this pull request as draft May 23, 2022 15:38
@shortcuts
Copy link
Member Author

draft until I update the cache, lock should clear cache 🤔

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should split the concern more between release ans normal CI, I feel like we are duplicating stuff

.map((commitMessage) => {
const commit = parseCommit(commitMessage);

if ('error' in commit) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could have 'error: null' in ParsedCommit for a cleaner check here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, will also apply it!

@shortcuts shortcuts marked this pull request as ready for review May 24, 2022 07:12
@shortcuts
Copy link
Member Author

I think we should split the concern more between release ans normal CI, I feel like we are duplicating stuff

I'm doing an other PR to try to prevent duplicate stuff and make the version bump possible

@shortcuts shortcuts requested a review from millotp May 24, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants