Build: Sdk code generation #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 25, 2022
winder
approved these changes
May 26, 2022
| # | ||
| # ============================================================ | ||
|
|
||
| git config credential.helper '!f() { sleep 1; echo "username=${GITHUB_USER}"; echo "password=${GITHUB_TOKEN}"; }; f' |
There was a problem hiding this comment.
Looks like you could also use the github cli for this:
https://cli.github.com/manual/gh_auth_login
gh auth login --with-token < ${GITHUB_TOKEN}
There was a problem hiding this comment.
Yeah, that seems simpler than what we have here.
| - [$INDEXER_SPEC_HASH]($INDEXER_REPO_URL/commit/$INDEXER_SPEC_HASH) - $INDEXER_SPEC_COMMIT_MSG | ||
|
|
||
|
|
||
| > **Disclaimer:** I'm just a bot. Feel free to make changes to this pull request as needed." |
There was a problem hiding this comment.
Nice touch with this PR body and links to the spec
There was a problem hiding this comment.
Thanks but I can't really take credit as I copied this over from https://github.com/algorand/generator/blob/master/automation/publish.sh#L109 😸
Co-authored-by: Will Winder <wwinder.unh@gmail.com>
Co-authored-by: Will Winder <wwinder.unh@gmail.com>
Co-authored-by: Will Winder <wwinder.unh@gmail.com>
Co-authored-by: Will Winder <wwinder.unh@gmail.com>
Co-authored-by: Will Winder <wwinder.unh@gmail.com>
algojack
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a github action which can be used by SDKs to automatically generate code and open pull requests.
Currently this automation resides in https://github.com/algorand/generator/tree/master/automation as well as in some of the SDK repos themselves, but it has some issues from lack of maintenance and isn't being used.
The
publish.shfile I've taken nearly exactly from what the existing script as it just works.The
entrypoint.shis a mix of thescripts/generate_{language}.shand the existingDockerfilein the automation.I've moved all of this into a Github Action so that we can have a central location that defines our code generation logic, and then utilize that across each of our SDK repos via a nightly workflow.
Testing
I've run the workflow on my personal forks (so there may be some permissions issues to sort out once we merge this), and have successful runs for generating a PR:
https://github.com/Eric-Warehime/go-algorand-sdk/actions/runs/2386518280
Eric-Warehime/go-algorand-sdk#1 (comes from an outdated indexer API spec so ignore the content)
And I have gotten a run which successfully no-ops because the branch with generated changes already exists:
https://github.com/Eric-Warehime/go-algorand-sdk/actions/runs/2386615221