Skip to content

Apps: Make sure reject version param gets serialized to message pack format #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

Apps: Make sure reject version param gets serialized to message pack format #1007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/transaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,6 +588,7 @@ export class Transaction implements encoding.Encodable {
),
},
{ key: 'apep', valueSchema: new OptionalSchema(new Uint64Schema()) },
{ key: 'aprv', valueSchema: new OptionalSchema(new Uint64Schema()) },
// StateProof
{ key: 'sptype', valueSchema: new OptionalSchema(new Uint64Schema()) },
{ key: 'sp', valueSchema: new OptionalSchema(StateProof.encodingSchema) },
Expand Down
7 changes: 5 additions & 2 deletions tests/5.Transaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2643,8 +2643,11 @@ describe('Application Resources References', () => {
const encodingData = txnWithRejectVersion.toEncodingData();
assert.strictEqual(encodingData.get('aprv'), 5);

// Note: Serialization/deserialization test temporarily removed due to msgpack decoding issue
// The core functionality works correctly as verified by other tests
// Test serialization/deserialization
const encodedTxn =
algosdk.encodeUnsignedTransaction(txnWithRejectVersion);
const decodedTxn = algosdk.decodeUnsignedTransaction(encodedTxn);
assert.strictEqual(decodedTxn.applicationCall?.rejectVersion, 5);

// Test with default rejectVersion (should be 0)
const txnDefaultRejectVersion = algosdk.makeApplicationCallTxnFromObject({
Expand Down
Loading