Skip to content

Conversation

cce
Copy link
Contributor

@cce cce commented Sep 5, 2025

@cce cce added the Enhancement label Sep 5, 2025
@cce cce changed the title Support lmsig logicsig signatures Txn: support lmsig logicsig signatures Sep 5, 2025
@cce cce changed the title Txn: support lmsig logicsig signatures Signatures: support lmsig logicsig signatures Sep 5, 2025
@cce cce requested a review from Copilot September 5, 2025 19:32
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for lmsig (logic signature multisignature) signatures, extending the existing multisignature functionality in the SDK. This appears to be a new signature format that differentiates multisig signatures on logic signatures from regular multisig signatures.

  • Updates LogicSig class to support lmsig field alongside existing msig field
  • Modifies signature verification logic to handle both legacy msig and new lmsig formats
  • Updates test files to use the new lmsig format and adds comprehensive test coverage

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/resources/msig_delegated_other.txn Test resource file with multisig delegated transaction using lmsig
tests/resources/msig_delegated.txn Test resource file with multisig delegated transaction using lmsig
tests/8.LogicSig.ts Updated test cases to support and verify lmsig functionality
src/signing.ts Modified to check lmsig instead of legacy msig for address derivation
src/logicsig.ts Core implementation adding lmsig support with separate signing and verification logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gmalouf gmalouf requested a review from jannotti September 5, 2025 19:45
@cce cce requested review from gmalouf and algorandskiy September 8, 2025 16:22
@cce cce merged commit 03c94cc into algorand:main Sep 8, 2025
9 checks passed
@cce cce deleted the lmsig branch September 8, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants