-
Notifications
You must be signed in to change notification settings - Fork 7
feat: adds typed block endpoint models; minor fixes in generators; fixes to nodely endpoints #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a674ed2
to
c239e40
Compare
a8914c1
to
f93447f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive Block schema and SignedTxnInBlock model to enhance type safety for block endpoints. Additionally, it migrates several endpoints to msgpack-only format and updates base URLs to use Nodely instead of Algonode.
Key changes:
- Added typed Block and SignedTxnInBlock models with proper field mappings
- Migrated pending transaction and block endpoints to msgpack-only format
- Updated client endpoints from algonode.cloud to nodely.dev
- Enhanced serialization runtime to handle flattened fields
Reviewed Changes
Copilot reviewed 52 out of 53 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
packages/typescript/kmd_client/src/core/model-runtime.ts | Enhanced serialization to handle flattened field structures |
packages/typescript/indexer_client/src/core/model-runtime.ts | Enhanced serialization to handle flattened field structures |
packages/typescript/algokit_utils/tests/algod/pendingTransaction.test.ts | Removed explicit format parameter from pending transaction call |
packages/typescript/algokit_utils/tests/algod/block.test.ts | Added new test for block endpoint with typed validation |
packages/typescript/algod_client/src/models/signed-txn-in-block.ts | Added comprehensive SignedTxnInBlock model with proper field mappings |
packages/typescript/algod_client/src/models/index.ts | Exported new Block and SignedTxnInBlock models |
packages/typescript/algod_client/src/models/get-block.ts | Updated to use typed Block model instead of generic object |
packages/typescript/algod_client/src/models/block.ts | Added comprehensive Block model with all header and transaction fields |
packages/typescript/algod_client/src/core/model-runtime.ts | Enhanced serialization to handle flattened field structures |
packages/typescript/algod_client/src/apis/api.service.ts | Migrated endpoints to msgpack-only format |
crates/algokit_utils/tests/algod/pending_transaction_information.rs | Removed explicit format parameter from pending transaction call |
crates/algokit_utils/tests/algod/mod.rs | Added block test module |
crates/algokit_utils/tests/algod/block.rs | Added new Rust test for block endpoint validation |
crates/algokit_utils/src/transactions/composer.rs | Removed explicit format parameter from pending transaction call |
crates/algokit_utils/src/clients/client_manager.rs | Updated base URLs from algonode.cloud to nodely.dev |
crates/algokit_http_client/src/lib.rs | Added header normalization for case-insensitive lookups |
crates/algod_client/src/msgpack_value_bytes.rs | Added msgpack value serialization module |
crates/algod_client/src/models/signed_txn_in_block.rs | Added Rust SignedTxnInBlock model with flattened SignedTransaction |
crates/algod_client/src/models/mod.rs | Exported new Block and SignedTxnInBlock models |
crates/algod_client/src/models/get_block.rs | Updated to use typed Block model |
crates/algod_client/src/models/block.rs | Added comprehensive Rust Block model |
crates/algod_client/src/lib.rs | Exported msgpack_value_bytes module |
crates/algod_client/src/apis/client.rs | Removed format parameters from msgpack-only endpoints |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
api/oas_generator/rust_oas_generator/templates/models/model.rs.j2
Outdated
Show resolved
Hide resolved
1cefbef
to
ad67a8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 55 out of 56 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/typescript/algod_client/src/models/signed-txn-in-block.ts
Outdated
Show resolved
Hide resolved
api/oas_generator/ts_oas_generator/templates/models/block/signed-txn-in-block.ts.j2
Outdated
Show resolved
Hide resolved
df64772
to
a60d6fb
Compare
🎉 This PR is included in version 1.0.0-alpha.77 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Adds comprehensive Block schema and SignedTxnInBlock model, enhancing type safety.
Also: