Skip to content

Conversation

aorumbayev
Copy link
Collaborator

@aorumbayev aorumbayev commented Oct 6, 2025

Adds comprehensive Block schema and SignedTxnInBlock model, enhancing type safety.

Also:

  • Adds manual templates specifically for the complex block endpoint response

@aorumbayev aorumbayev force-pushed the feat/typed-block-endpoint branch from a674ed2 to c239e40 Compare October 6, 2025 21:49
@aorumbayev aorumbayev force-pushed the feat/typed-block-endpoint branch from a8914c1 to f93447f Compare October 7, 2025 17:02
@aorumbayev aorumbayev marked this pull request as ready for review October 7, 2025 17:33
@aorumbayev aorumbayev requested a review from a team as a code owner October 7, 2025 17:33
@aorumbayev aorumbayev requested review from PatrickDinh and Copilot and removed request for a team October 7, 2025 17:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive Block schema and SignedTxnInBlock model to enhance type safety for block endpoints. Additionally, it migrates several endpoints to msgpack-only format and updates base URLs to use Nodely instead of Algonode.

Key changes:

  • Added typed Block and SignedTxnInBlock models with proper field mappings
  • Migrated pending transaction and block endpoints to msgpack-only format
  • Updated client endpoints from algonode.cloud to nodely.dev
  • Enhanced serialization runtime to handle flattened fields

Reviewed Changes

Copilot reviewed 52 out of 53 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/typescript/kmd_client/src/core/model-runtime.ts Enhanced serialization to handle flattened field structures
packages/typescript/indexer_client/src/core/model-runtime.ts Enhanced serialization to handle flattened field structures
packages/typescript/algokit_utils/tests/algod/pendingTransaction.test.ts Removed explicit format parameter from pending transaction call
packages/typescript/algokit_utils/tests/algod/block.test.ts Added new test for block endpoint with typed validation
packages/typescript/algod_client/src/models/signed-txn-in-block.ts Added comprehensive SignedTxnInBlock model with proper field mappings
packages/typescript/algod_client/src/models/index.ts Exported new Block and SignedTxnInBlock models
packages/typescript/algod_client/src/models/get-block.ts Updated to use typed Block model instead of generic object
packages/typescript/algod_client/src/models/block.ts Added comprehensive Block model with all header and transaction fields
packages/typescript/algod_client/src/core/model-runtime.ts Enhanced serialization to handle flattened field structures
packages/typescript/algod_client/src/apis/api.service.ts Migrated endpoints to msgpack-only format
crates/algokit_utils/tests/algod/pending_transaction_information.rs Removed explicit format parameter from pending transaction call
crates/algokit_utils/tests/algod/mod.rs Added block test module
crates/algokit_utils/tests/algod/block.rs Added new Rust test for block endpoint validation
crates/algokit_utils/src/transactions/composer.rs Removed explicit format parameter from pending transaction call
crates/algokit_utils/src/clients/client_manager.rs Updated base URLs from algonode.cloud to nodely.dev
crates/algokit_http_client/src/lib.rs Added header normalization for case-insensitive lookups
crates/algod_client/src/msgpack_value_bytes.rs Added msgpack value serialization module
crates/algod_client/src/models/signed_txn_in_block.rs Added Rust SignedTxnInBlock model with flattened SignedTransaction
crates/algod_client/src/models/mod.rs Exported new Block and SignedTxnInBlock models
crates/algod_client/src/models/get_block.rs Updated to use typed Block model
crates/algod_client/src/models/block.rs Added comprehensive Rust Block model
crates/algod_client/src/lib.rs Exported msgpack_value_bytes module
crates/algod_client/src/apis/client.rs Removed format parameters from msgpack-only endpoints

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@aorumbayev aorumbayev marked this pull request as draft October 8, 2025 11:44
@aorumbayev aorumbayev force-pushed the feat/typed-block-endpoint branch from 1cefbef to ad67a8d Compare October 8, 2025 21:13
@aorumbayev aorumbayev marked this pull request as ready for review October 8, 2025 23:17
@aorumbayev aorumbayev requested review from Copilot and joe-p October 8, 2025 23:17
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 55 out of 56 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@aorumbayev aorumbayev force-pushed the feat/typed-block-endpoint branch from df64772 to a60d6fb Compare October 8, 2025 23:22
@aorumbayev aorumbayev merged commit 0bed469 into main Oct 10, 2025
21 checks passed
@aorumbayev aorumbayev deleted the feat/typed-block-endpoint branch October 10, 2025 10:24
@engineering-ci
Copy link
Contributor

🎉 This PR is included in version 1.0.0-alpha.77 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants