Skip to content

Conversation

aorumbayev
Copy link
Collaborator

@aorumbayev aorumbayev commented Oct 8, 2025

Proposed Changes

  • refining format query param handling in msgpack only endpoints; patching eslint warnings in generated ts clients
  • typo in pre commit

@aorumbayev aorumbayev requested a review from a team as a code owner October 8, 2025 17:00
@aorumbayev aorumbayev requested review from Copilot and joe-p and removed request for a team October 8, 2025 17:00
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines format query parameter handling for msgpack-only endpoints and fixes a typo in the pre-commit configuration. The changes remove format parameters from endpoints that only support msgpack, ensuring consistent msgpack usage across TypeScript and Rust clients while simplifying the API surface.

  • Updates msgpack-only endpoints to force msgpack format without exposing format parameters
  • Fixes body variable naming in TypeScript request handlers for better clarity
  • Changes pre-commit configuration from cargo nextest run to cargo t

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/typescript/*/src/core/request.ts Renamed body variable to bodyPayload for clarity and improved type handling
packages/typescript/*/src/apis/api.service.ts Added helper methods for format handling and replaced inline format logic
packages/typescript/algokit_utils/tests/algod/pendingTransaction.test.ts Removed format parameter from test calls
crates/*/src/apis/*.rs Removed format parameters from msgpack-only endpoints
crates/algokit_utils/src/clients/client_manager.rs Updated Algorand node URLs and enhanced test coverage
api/oas_generator/ Enhanced generators to detect and handle msgpack-only endpoints
.pre-commit-config.yaml Fixed typo in cargo command

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@aorumbayev aorumbayev merged commit 0407437 into main Oct 8, 2025
21 checks passed
@aorumbayev aorumbayev deleted the feat/api-refinements branch October 8, 2025 17:13
@engineering-ci
Copy link
Contributor

engineering-ci bot commented Oct 8, 2025

🎉 This PR is included in version 1.0.0-alpha.75 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants