feat: network, client, asset managers in ts; minor refinements in rs and ts to further align with legacy utils-ts #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aorumbayev
force-pushed
the
feat/ts-client-asset-managers
branch
from
7252adb to
a8d0196
Compare
aorumbayev
force-pushed
the
feat/ts-client-asset-managers
branch
from
70e4681 to
6c2cfef
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request implements key client abstractions and management utilities for the TypeScript AlgoKit Utils package, aligning functionality with the existing Rust implementation. The changes focus on providing NetworkClient, ClientManager, and AssetManager with comprehensive testing coverage.
- Adds NetworkClient, ClientManager, and AssetManager implementations in TypeScript
- Implements comprehensive test coverage for all new client abstractions
- Consolidates common test utilities under algokit-common package
- Updates field naming conventions to align with legacy utils-ts (e.g.,
unit_name_b64→unit_name_bytes)
Reviewed Changes
Copilot reviewed 31 out of 32 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/typescript/package.json | Adds new npm scripts for linting and formatting |
| packages/typescript/algokit_utils/src/clients/ | Implements core client management abstractions |
| packages/typescript/algokit_utils/tests/clients/ | Comprehensive test coverage for new client functionality |
| packages/typescript/algokit_common/tests/helpers.ts | Consolidated test utilities moved from individual packages |
| crates/algokit_utils/src/clients/ | Field naming updates and batch processing improvements in Rust |
Files not reviewed (1)
- packages/typescript/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aorumbayev
force-pushed
the
feat/ts-client-asset-managers
branch
from
ac5eb6e to
4c70c52
Compare
PatrickDinh
reviewed
Oct 17, 2025
packages/typescript/algokit_utils/tests/indexer/searchApplications.test.ts
Show resolved
Hide resolved
aorumbayev
force-pushed
the
feat/ts-client-asset-managers
branch
2 times, most recently
from
1661920 to
763597e
Compare
aorumbayev
force-pushed
the
feat/ts-client-asset-managers
branch
from
763597e to
ca68e91
Compare
aorumbayev
force-pushed
the
feat/ts-client-asset-managers
branch
2 times, most recently
from
8d8f4df to
ceb7a80
Compare
aorumbayev
force-pushed
the
feat/ts-client-asset-managers
branch
from
ceb7a80 to
0425f83
Compare
Contributor
|
🎉 This PR is included in version 1.0.0-alpha.79 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Additionally adds test equivalents of tests available for same abstractions in utils crate. Removes most of dependencies on algosdk, adds dependencies on generated algod indexer and kmd, consolidates common helpers under algokit-common package. Adds minor refinements to batch methods in asset manager in both ts and rust to further align with capabilities in legacy utils-ts, as well as minor refinements in further alignment of certain field names (for ex unit_name_b64 - unit_name_bytes).