fix: addressing internal feedback (batch 6)

[aorumbayev]

Proposed Changes

• ensure root of unnamed resources response is parsed into typed class (which is a root cause of an error reported by Brian)
• align error message thrown during errors in resource population with ts (reported by Neil)

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
src/algokit_utils
_debugging.py	141	18	87%	21, 40–42, 45, 54, 62, 81, 87, 96, 110–114, 133, 141–143
account.py	3	3	0%	1–12
algorand.py	98	15	85%	62–63, 74–75, 95–96, 108–110, 119–120, 214, 234, 247, 263
application_client.py	3	3	0%	1–11
application_specification.py	7	7	0%	1–39
config.py	78	21	73%	23, 30–34, 73–74, 90, 95, 100, 111–116, 141, 144–146, 149, 151
deploy.py	3	3	0%	1–10
logic_error.py	3	3	0%	1–10
src/algokit_utils/_legacy_v2
_ensure_funded.py	71	1	99%	100
_transfer.py	70	3	96%	14, 75–76
account.py	93	13	86%	15–18, 70–74, 109, 126, 156, 159, 203
application_client.py	537	77	86%	56–57, 176, 181, 210, 322, 327–328, 330, 332, 801, 816, 834–837, 931, 971, 983, 996, 1038, 1098–1104, 1108–1113, 1115, 1151, 1158, 1271, 1307, 1321, 1359–1361, 1363, 1373–1430, 1441–1446, 1466–1469
asset.py	80	4	95%	24–27
common.py	13	1	92%	13
deploy.py	407	22	95%	32–35, 170, 174–175, 193, 249, 339–340, 361, 395, 406–414, 429, 437, 593–594, 618
network_clients.py	73	5	93%	77–78, 101–102, 135
src/algokit_utils/accounts
account_manager.py	212	33	84%	161, 180–181, 205–210, 228–229, 246, 263–268, 315–317, 346, 385, 405–409, 422, 481, 502, 659, 765, 844, 849, 868–869, 892
kmd_account_manager.py	74	10	86%	49–55, 96, 152, 159
src/algokit_utils/applications
abi.py	132	71	46%	14, 77, 113, 119, 121, 123, 127–128, 143–162, 178, 181–187, 203–216, 229–241, 256–267
app_client.py	704	214	70%	66–74, 133, 141, 335–338, 341, 344, 347, 350, 362–365, 368, 371, 374, 377, 389, 398, 407, 410–477, 490–548, 572–574, 591–594, 602–605, 613–616, 624–627, 635–638, 649–652, 665, 761–764, 798, 810, 822, 834, 846, 861, 876, 886, 896, 906, 916, 926, 963–976, 992, 1009, 1026, 1043, 1064, 1085, 1175, 1343, 1390–1391, 1422, 1424, 1430, 1475–1483, 1516–1519, 1522–1525, 1546, 1594, 1657–1659, 1672–1679, 1720, 1737, 1739, 1742, 1746, 1873, 1884–1885, 1913, 1923–1925, 1928–1950, 1960, 1969–1984, 1989–1994
app_deployer.py	214	35	84%	98, 196, 203, 213–218, 221–225, 297–298, 507, 516–519, 532, 537, 543, 552–557, 564, 578, 589–630
app_factory.py	266	27	90%	351, 361, 364, 508, 516, 528, 677, 691–696, 702–703, 721, 746, 757–758, 794, 802–816
app_manager.py	218	16	93%	226, 285–286, 318–323, 349, 367–368, 398, 419–422, 445, 454
src/algokit_utils/applications/app_spec
arc32.py	95	8	92%	198–207
arc56.py	470	36	92%	72–74, 183, 318, 336–337, 415, 437–439, 495, 504, 506, 574, 769, 779, 783, 943, 945, 978–989, 1002, 1004–1005, 1021
src/algokit_utils/assets
asset_manager.py	106	12	89%	266–267, 276, 282–306, 316
src/algokit_utils/clients
client_manager.py	173	54	69%	24–26, 74–81, 95, 127–129, 185, 196–199, 224, 263, 298–303, 338–340, 373, 390, 412, 446–449, 482–485, 519–522, 552–555, 573–598, 628, 637, 645
dispenser_api_client.py	84	12	86%	129–130, 134–137, 172–174, 193–195
src/algokit_utils/errors
logic_error.py	56	11	80%	14, 105–121
src/algokit_utils/models
account.py	92	15	84%	32, 34, 80–81, 128, 136, 144, 168–175, 188, 196, 209, 217
amount.py	106	17	84%	35, 42, 88, 98, 104, 112, 117–119, 126, 131–133, 140, 147, 160, 166
application.py	42	1	98%	8
state.py	36	5	86%	51, 55–58
transaction.py	51	3	94%	66, 86, 91
src/algokit_utils/protocols
account.py	11	2	82%	17, 22
typed_clients.py	24	4	83%	12–24
src/algokit_utils/transactions
transaction_composer.py	966	110	89%	34–41, 601, 640, 643, 648, 652–663, 695, 736, 803, 810, 832, 865, 962–991, 1020, 1038–1040, 1046–1061, 1066, 1074, 1076, 1078, 1094, 1100, 1138, 1146, 1159, 1253, 1303, 1552–1553, 1592–1593, 1634, 1845, 1848, 1867, 1872, 1896–1898, 1935–1971, 1978–1985, 2126, 2130, 2261, 2263–2264, 2314–2315
transaction_creator.py	75	7	91%	116, 121, 126, 131, 136, 141, 156
transaction_sender.py	148	10	93%	88, 243, 286–287, 431–436, 441–442, 487
TOTAL	6263	912	85%

Tests	Skipped	Failures	Errors	Time
402	0 💤	0 ❌	0 🔥	5m 53s ⏱️

[neilcampbell]

I'm curious why the resource population tests didn't flag this as a problem.

[aorumbayev]

@neilcampbell we haven't had tests for certain unnamed resources fields from the response such as asset-holding and etc. Hence went unnoticed as main use cases were covered by tests identical to uitls. The change in the pr ensures that entire response body is parsed into a typed object.