fix: ensure getMap works properly with prefix #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-p
force-pushed
the
fix/get_state_map
branch
2 times, most recently
from
403f00f to
9d5ad00
Compare
joe-p
force-pushed
the
fix/get_state_map
branch
from
9d5ad00 to
ff8f9ea
Compare
lempira
approved these changes
Apr 11, 2025
Contributor
lempira
left a comment
lempira
left a comment
There was a problem hiding this comment.
LGTM. Just a comment on tsconfig commented code.
| @@ -0,0 +1,103 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
Do we need all of the commented boilerplate configs for the example?
Contributor
Author
There was a problem hiding this comment.
Yeah good point. I reduced it to just what is recommended for TEALScript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getMapwas erroneously setting the prefix twice which resulted in the boxes not being found.Note: I originally planned to write the test contract with Algorand TypeScript, but it had a bug generating ARC56 state maps