[ISSUE #4770] Beta publish: change the way of select betaIps, from input to select #5493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoyann
reviewed
Apr 25, 2021
| value={betaIps} | ||
| onChange={betaIps => this.setState({ betaIps })} | ||
| <Select | ||
| size="medium" |
There was a problem hiding this comment.
I think use tag mode better, allow input as an option.
doc:https://fusion.design/pc/component/select?themeid=2
There was a problem hiding this comment.
Yes, It's better to use tag mode if we allow users to input the betaIps which are not in the current Ip list.
|
This PR conflicts with the develop branch, I will resolve the conflicts and re-submit later. |
…libaba#4770 � Conflicts: � console/src/main/resources/static/js/main.js
|
the result after change: |
haoyann
approved these changes
Apr 26, 2021
KomachiSion
approved these changes
Apr 27, 2021
KomachiSion
added
area/Nacos console
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
Fixes #4770
change the way of select betaIps, from input to select.
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.