Skip to content

Conversation

dlh01
Copy link
Member

@dlh01 dlh01 commented Jan 1, 2017

This aims to improve Fieldmanager's readiness for translation, such as the Italian translation by @enrico-sorcinelli in #508, and address issues raised in that PR and by PHPCS.

The changes here include:

dlh01 added 10 commits December 29, 2016 20:58
- Use sentence case and end strings with periods, with some exceptions like button labels.
- Consistently capitalize labels (e.g. "Remove").
- Use Markdown for inline formatting (notably `code`).
- Merge similar strings (e.g. "User cannot" vs. "Current user cannot").
- Use placeholders for previously untranslateable dynamic text.
@enrico-sorcinelli
Copy link
Contributor

Hi @dlh01,
It looks good. This PR does the same thing I proposed in mine and moreover fixes all the remaining syntax messages issues and rightly adds a grunt task to generate .pot (I used mine).

Why this PR has not been merged yet to the master?

Then, I could send new one PR for the updated italian .po / .mo files and the i18n PHPunit test that I already wrote.

@dlh01
Copy link
Member Author

dlh01 commented Feb 25, 2017

@enrico-sorcinelli Thanks for reviewing the changes. I think the PR needs more testing and feedback from FM maintainers and other users before it's merged.

@mboynes mboynes added this to the 1.3.0 milestone Oct 10, 2017
@mslinnea
Copy link
Member

Hey @dlh01,
I've started looking into updating this branch and have a question. For some of these merge conflicts, the difference is that in this branch, there are backticks used instead of quotes. For example:

/* translators: %s: property name */
wp_die( esc_html( sprintf( __( 'Tried to refer to user %s which current user cannot edit.', 'fieldmanager' ), "`{$v}`" ) ) );

versus on master branch:

/* translators: %s: user id */
wp_die( esc_html( sprintf( __( 'Tried to refer to user "%s" which current user cannot edit.', 'fieldmanager' ), $v ) ) );

I'm wondering what the reason was to use backticks and whether you still think that's preferable?

@dlh01
Copy link
Member Author

dlh01 commented Nov 11, 2020

@mslinnea The backticks were (are) an attempt to format the strings with Markdown based on how I thought they might be written as HTML. I'm not particularly wedded to it. It was just something to facilitate consistency among strings across the plugin.

@dlh01 dlh01 modified the milestones: 1.4.0, 1.5.0 Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants