-
Notifications
You must be signed in to change notification settings - Fork 98
Update translated strings #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Use sentence case and end strings with periods, with some exceptions like button labels. - Consistently capitalize labels (e.g. "Remove"). - Use Markdown for inline formatting (notably `code`). - Merge similar strings (e.g. "User cannot" vs. "Current user cannot"). - Use placeholders for previously untranslateable dynamic text.
Hi @dlh01, Why this PR has not been merged yet to the master? Then, I could send new one PR for the updated italian .po / .mo files and the i18n PHPunit test that I already wrote. |
@enrico-sorcinelli Thanks for reviewing the changes. I think the PR needs more testing and feedback from FM maintainers and other users before it's merged. |
Hey @dlh01,
versus on master branch:
I'm wondering what the reason was to use backticks and whether you still think that's preferable? |
@mslinnea The backticks were (are) an attempt to format the strings with Markdown based on how I thought they might be written as HTML. I'm not particularly wedded to it. It was just something to facilitate consistency among strings across the plugin. |
This aims to improve Fieldmanager's readiness for translation, such as the Italian translation by @enrico-sorcinelli in #508, and address issues raised in that PR and by PHPCS.
The changes here include:
.pot
file viagrunt-wp-i18n
(1d07126) and a call toload_plugin_textdomain()
(cef2b3f).<code>
tags in core (e.g. https://core.trac.wordpress.org/changeset/39254, https://core.trac.wordpress.org/changeset/35548).