forked from cosmos/interchain-security
-
Notifications
You must be signed in to change notification settings - Fork 0
feat!: ICS1 with RS POC experiment #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
n2p5
wants to merge
34
commits into
v5.2.0-fork
Choose a base branch
from
atomone-replicated-security-poc
base: v5.2.0-fork
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0ab4bd
to
354f839
Compare
354f839
to
0d95b37
Compare
Discoveries:
This has been interesting and somewhat of a rabbit hole I've been going down, but I think I'll have some POC worthy code soon (maybe I am too optimistic here). |
feat: POC of ibc-10 upgrade
I've merged the work of the IBC v10 experiment into this POC branch for simplicity, putting this link here for traceability and so that it is easy to diff this major change to this experiment. #3 |
feat: update core deps and remove x/crisis
feat: apply pr 2098 (provider-side removal of vscmatured packet) to our ics module
20 tasks
feat: remove legacy migration and simplify deps
* chore: update tag filter for e2e build * feat: fix e2e testing for simple test * chore: code cleanup * chore: code cleanup * chore: code cleanup * chore: update CI go version and remove e2e compat test * chore: fix ci workers * chore: fix ci workers * chore: fix ci workers * fix: integration tests * fix: remove sonarcloud from CI * chore: debug logging cleanup * chore: debug logging cleanup * fix: remove pss refs in e2e * chore: remove some dead docs * fix: restore documentation files from 7f8a868 * fix: make small changes with PR feedback * fix: typo in e2e steps
* feat: reintroduce TopN * chore: fix diff formatting * chore: ensure tx.proto has all required fields * fix: restore tx comments * fix: restore tx.proto formatting * fix: reintroduce TopN state functions for keeper.go * fix: reintroduce TopN state functions for keeper.go * fix: finish TopN first pass with testing * fix: update integration tests for TopN * fix: TopN test coverage * fix: all testing * fix: update testing signatures * fix: cleaning up diffs
…10) - Add NewChainId field to MsgConsumerModification - Implement renameConsumerChain to migrate all chain-scoped state - Extend HandleConsumerModificationProposal with prelaunch rename logic - Add comprehensive tests covering all control-flow paths - Update CLI and tx.proto accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AtomOne ICS1: Pure Replicated Security Implementation
Overview
This PR creates ICS1 - a fork of Interchain Security v5.2.0 that implements pure
Replicated Security for AtomOne. All Partial Set Security (PSS) features have been
removed, ensuring that ALL bonded validators must validate ALL consumer chains,
providing maximum security guarantees.
Key Changes
Pure Replicated Security
AtomOne Compatibility
Other Improvements
Merged PRs
This branch consolidates work from multiple PRs:
#3 - IBC v10 Upgrade
#4 - AtomOne Gov Compatibility
#5 - Dependency Alignment
#6 - VSCMatured Packet Removal
#7 - Legacy Migration Cleanup
#8 - E2E & Integration Test Fixes
#9 - Reintroduce TopN
#10 - add support for updating consumer chain-id
Testing Status
✅ All unit tests passing
✅ E2E tests passing
✅ Integration tests passing
What's NOT Included (Future Work)
From Upstream v6/v7
AtomOne Specific
Breaking Changes
Usage
This fork is designed for AtomOne mainnet deployment where:
Review Focus
Please review:
Note: This is an intentional fork with breaking changes. We're not seeking to
merge upstream but rather maintaining a specialized version for AtomOne's security
model.
Summary: This PR successfully removes ~12,000 lines of PSS code while maintaining a clean, working Replicated Security implementation. The actual logic changes are minimal and focused, making this a surgical removal rather than a refactor.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if the change is state-machine breakingCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
the type prefix if the change is state-machine breaking