forked from cosmos/interchain-security
-
Notifications
You must be signed in to change notification settings - Fork 0
chore: update tag filter for e2e build #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for assigning me the review, learned a lot more about ccv.
masonmcbride
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICS1 AtomOne E2E and Integration Changes
Quick summary of what we had to fix to get ICS working with AtomOne's SDK fork.
Key Fixes
AtomOne SDK Compatibility
VersionModifier
implementation - AtomOne SDK requires this for ABCI queries to workTest Timing Adjustments
Test Script Fixes
read
commands that blocked automationIntegration Tests
Same fixes as E2E plus:
Other Changes
Result
All E2E and integration tests passing. Coverage: 31.2% (this should be higher?)
Notes
ICS1
comments in code