Skip to content

Conversation

n2p5
Copy link
Collaborator

@n2p5 n2p5 commented Sep 2, 2025

ICS1 AtomOne E2E and Integration Changes

Quick summary of what we had to fix to get ICS working with AtomOne's SDK fork.

Key Fixes

AtomOne SDK Compatibility

  • Added VersionModifier implementation - AtomOne SDK requires this for ABCI queries to work
  • Fixed light client module registration for IBC v10
  • Fixed IBC port naming: use "consumer" not "ccvconsumer"

Test Timing Adjustments

  • Increased slashing windows (10 -> 50 blocks provider, 20 -> 100 consumer) for reliability of tests
  • Increased downtime wait to 51 blocks to actually trigger slashing with new windows
  • Increased unjail wait to 90 seconds to match AtomOne's timing

Test Script Fixes

  • Query height 1 instead of 0 (blocks start at 1 now)
  • Removed interactive read commands that blocked automation

Integration Tests

Same fixes as E2E plus:

  • Removed commission withdrawal tests (validators have zero commission in RS)
  • Fixed consumer-democracy app missing IBC setup
  • Updated tests to not expect VSCMatured packets (removed in ICS1)
  • Fixed double voting test for CometBFT v0.38 vote extensions
  • Fixed IBC router access for transfer middleware tests

Other Changes

  • Removed SonarCloud CI job (not used)
  • Removed debug logging that was killing performance

Result

All E2E and integration tests passing. Coverage: 31.2% (this should be higher?)

Notes

  • Most issues stem from AtomOne SDK differences and IBC v10 changes
  • Timing is calibrated for AtomOne's block production rate
  • All changes marked with ICS1 comments in code

@github-actions github-actions bot added the C:CI label Sep 11, 2025
Copy link

@masonmcbride masonmcbride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for assigning me the review, learned a lot more about ccv.

@n2p5 n2p5 requested a review from masonmcbride September 13, 2025 03:01
@n2p5 n2p5 merged commit acde56e into atomone-replicated-security-poc Sep 15, 2025
9 checks passed
@n2p5 n2p5 deleted the ics1-e2e-patch branch September 15, 2025 17:53
@n2p5 n2p5 mentioned this pull request Sep 15, 2025
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants