Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use EncodableSignature for tx encoding #1100

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

leruaa
Copy link
Contributor

@leruaa leruaa commented Jul 24, 2024

Motivation

Closes #1077

Note: The following PR in alloy-core need to be merged first: alloy-rs/core#692

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mattsse mattsse merged commit 2ce8525 into alloy-rs:main Jul 25, 2024
22 checks passed
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
* feat: use EncodableSignature for tx encoding

* feat: integrate EncodableSignature in alloy directly
@leruaa leruaa deleted the use_encodable_signature_for_tx_encoding branch October 10, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] allow any signature type for tx encoding
2 participants