feat: add prague engine types #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested review from
DaniPopes,
gakonst,
onbjerg,
prestwich and
Evalir
as code owners
DaniPopes
reviewed
Apr 17, 2024
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
onbjerg
approved these changes
Apr 17, 2024
Comment on lines
+19
to
+22
| /// Deposit signature | ||
| pub signature: FixedBytes<96>, | ||
| /// Deposit index | ||
| #[serde(with = "alloy_serde::u64_hex")] |
There was a problem hiding this comment.
i assume these are exit sig/exit index?
There was a problem hiding this comment.
honestly no idea
index field
The index field may appear unnecessary but it is important information for deposit processing flow on the Consensus Layer.
not very helpful -.-
There was a problem hiding this comment.
where do you see this? i don't see the comment in https://github.com/ethereum/execution-apis/blob/main/src/engine/prague.md#exitv1
There was a problem hiding this comment.
in fact, a lot of the fields are not present in that doc.. is it out of date?
Co-authored-by: Oliver Nordbjerg <onbjerg@users.noreply.github.com>
Co-authored-by: Oliver Nordbjerg <onbjerg@users.noreply.github.com>
ThreeHrSleep
pushed a commit
to ThreeHrSleep/alloy
that referenced
this pull request
Apr 17, 2024
* feat: add prague engine types * Update crates/eips/src/eip6110.rs Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com> * clippy * Update crates/eips/src/eip6110.rs Co-authored-by: Oliver Nordbjerg <onbjerg@users.noreply.github.com> * Update crates/rpc-types-engine/src/exit.rs Co-authored-by: Oliver Nordbjerg <onbjerg@users.noreply.github.com> --------- Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Co-authored-by: Oliver Nordbjerg <onbjerg@users.noreply.github.com>
mattsse
added a commit
that referenced
this pull request
Apr 17, 2024
* Move BlockId type to alloy-eip * suggested changes * touchups * chore: touchups * fix: tmp fix for PendingTransactionBuilder::get_receipt (#558) * feat: add prague engine types (#557) * feat: add prague engine types * Update crates/eips/src/eip6110.rs Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com> * clippy * Update crates/eips/src/eip6110.rs Co-authored-by: Oliver Nordbjerg <onbjerg@users.noreply.github.com> * Update crates/rpc-types-engine/src/exit.rs Co-authored-by: Oliver Nordbjerg <onbjerg@users.noreply.github.com> --------- Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Co-authored-by: Oliver Nordbjerg <onbjerg@users.noreply.github.com> * fix: add more generics to any and receipt with bloom (#559) * fix: signer fills from if unset (#555) * fix: override txtype during submission prep (#556) * Use the same way to both serialize and deserialize `OptimismPayloadAttributes::gas_limit`. (#563) * Use the same way to both serialize and deserialize `OptimismPayloadAttributes::gas_limit`. I understand that `op-reth` only ever deserializes this structure. My use case is to serialize this struct and pass it to `op-geth`. The latter expects it to be hex. * rustfmt --------- Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * feat: add ClientVersionV1 (#562) * added ClientVersionV1 * touchups * rustfmt --------- Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * clippy * use alloc --------- Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com> Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Co-authored-by: Oliver Nordbjerg <onbjerg@users.noreply.github.com> Co-authored-by: James Prestwich <james@prestwi.ch> Co-authored-by: Raman Hafiyatulin <r.gafiyatullin@me.com> Co-authored-by: guha-rahul <52607971+guha-rahul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds payload v4 type for https://github.com/ethereum/execution-apis/blob/main/src/engine/prague.md#depositreceiptv1
also adds https://eips.ethereum.org/EIPS/eip-6110 Deposit type
This does not yet enable V4 as supported variant to the payload enum, this will follow once reth is ready for this
ref paradigmxyz/reth#7363