Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tinsel bunting #3895

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Update tinsel bunting #3895

merged 2 commits into from
Dec 20, 2023

Conversation

MartinJJones
Copy link
Contributor

@MartinJJones MartinJJones commented Dec 18, 2023

What

Update the tinsel on the bank holidays page.

Tested in:

  • Chrome ✅
  • Safari ✅
  • Firefox ✅
  • IE11 ✅

Why

The existing tinsel is quite outdated now and is over 12KB in size
Trello card

Visual Changes

A temp commit has been added to allow the changes to be previewed on Heroku - https://govuk-frontend-app-pr-3895.herokuapp.com/bank-holidays

Desktop

Before After
tinsel-desktop-before tinsel-desktop-after

Mobile

Before After
tinsel-mobile-before tinsel-mobile-after

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-3895 December 18, 2023 11:04 Inactive
@MartinJJones MartinJJones marked this pull request as ready for review December 18, 2023 11:24
Copy link
Member

@hannalaakso hannalaakso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been able to physically test this on a really wide monitor but it sounds like you've done this Martin. I've had a look on a couple of other devices though, LGTM 🎄

Add styles for new festive lights tinsel bunting
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-3895 December 19, 2023 09:37 Inactive
@MartinJJones MartinJJones merged commit 0fb81f7 into main Dec 20, 2023
11 checks passed
@MartinJJones MartinJJones deleted the update-tinsel-bunting branch December 20, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants