Skip to content

Align Signature.create signature with current Amaranth. #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2023
Merged

Align Signature.create signature with current Amaranth. #61

merged 1 commit into from
Dec 11, 2023

Conversation

wanda-phi
Copy link
Member

This fixes fallout of amaranth-lang/amaranth#991.

Fixes #60.

@wanda-phi wanda-phi requested a review from jfng as a code owner December 9, 2023 12:02
jfng
jfng approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@jfng jfng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jfng jfng added this pull request to the merge queue Dec 11, 2023
Merged via the queue into amaranth-lang:main with commit ad9f7d4 Dec 11, 2023
@wanda-phi wanda-phi deleted the signature-create branch December 11, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark approved these changes

@jfng jfng jfng approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signature.create in amaranth-soc interfaces is incompatible with Signature.create from latest Amaranth
3 participants
@wanda-phi @whitequark @jfng