lib.enum: honor enum.nonmember. #1151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1151 +/- ##
==========================================
- Coverage 85.87% 85.87% -0.01%
==========================================
Files 43 43
Lines 8675 8674 -1
Branches 2065 2064 -1
==========================================
- Hits 7450 7449 -1
Misses 1025 1025
Partials 200 200 ☔ View full report in Codecov by Sentry. |
whitequark
approved these changes
Feb 19, 2024
|
Could you squash please? Also, let me know if you need a new 0.4.x series release; I've marked this PR as a backport but I only do actual backporting/releases when there is demand. |
Use _EnumDict._member_names to determine which members to consider. This way we don't need to redo sunder/dunder checks, and `nonmember`s (introduced in py3.11) are correctly excluded. This is a defacto public API, given it remains usable from py3.8 until py3.12 inclusive. (_member_names changes from a list to a keys-only dict for performance reasons in py3.11, but they iterate the same.) In current Python main (i.e. what will most likely be 3.13), a "member_names" property is added which returns those keys.
|
Squashed! And thanks re: the releases, understood! I'm living on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
_EnumDict._member_namesto determine which members to consider. This way we don't need to redo sunder/dunder checks, and non-members are correctly excluded.This is a defacto public API, given it remains usable from py3.8 until py3.12 inclusive. (
_member_nameschanges from a list to a keys-only dict for performance reasons in py3.11, but they iterate the same.) In current Python main (i.e. what will most likely be 3.13), amember_namesproperty is added which returns those keys.