Skip to content

Add a strobe generator (rfc #26) #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

galibert
Copy link
Contributor

@galibert galibert commented Sep 3, 2023

Possible implementation for the proposed rfc #26

@galibert galibert requested a review from whitequark as a code owner September 3, 2023 21:03
@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f135226) 83.91% compared to head (ddb3718) 85.57%.
Report is 48 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
+ Coverage   83.91%   85.57%   +1.66%     
==========================================
  Files          54       54              
  Lines        7621     8709    +1088     
  Branches     1847     2379     +532     
==========================================
+ Hits         6395     7453    +1058     
- Misses       1029     1057      +28     
- Partials      197      199       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whitequark whitequark marked this pull request as draft September 5, 2023 06:49
@whitequark
Copy link
Member

(Converted to a draft since a PR waiting on an RFC by definition cannot be merged. This makes it easier to parse the list of PRs.)

@galibert galibert closed this Oct 9, 2023
@galibert galibert reopened this Nov 22, 2023
@galibert galibert closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants