Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tree creation #23

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Fix tree creation #23

merged 3 commits into from
Jun 14, 2022

Conversation

Giulero
Copy link
Collaborator

@Giulero Giulero commented Jun 13, 2022

This pr should fix #17.

A cycle over the joints is added to ensure that a parent link is added to the parent list only if it is already in the link list.

This check allows the current loading of urdfs in which the joints order is not the one in the kinematic tree.

I'm also being less strict with the link with no inertia. Before the links with no inertial field in the urdf were skipped. Now I'm not skipping but adding a zero inertia in the computations.

@Giulero
Copy link
Collaborator Author

Giulero commented Jun 14, 2022

Thanks @valentino-razza ! :D

@Giulero Giulero merged commit f3e25c5 into main Jun 14, 2022
@Giulero Giulero deleted the Fix-tree.link-list-creation branch June 14, 2022 09:33
@traversaro
Copy link
Contributor

Now I'm not skipping but adding a zero inertia in the computations.

That can make quite a big performance difference in models with a lot of frames (i.e. link with zero mass), such as iCub. Did you consider have an option for this, or store them but in a different form (in iDynTree we store them as "additional frames", to avoid useless link in the computation).

@Giulero
Copy link
Collaborator Author

Giulero commented Jun 16, 2022

That can make quite a big performance difference in models with a lot of frames (i.e. link with zero mass), such as iCub. Did you consider have an option for this, or store them but in a different form (in iDynTree we store them as "additional frames", to avoid useless link in the computation).

You're right @traversaro! I could add an additional condition that allows only child links with inertia in the link list.
I'll use #24 for fixing this.

@Giulero Giulero mentioned this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Joint order in URDF file
3 participants