Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In methods like
forward_kinematics
orjacobian
, we need to access the kinematic tree that goes from the base frame to the end-effector. To get this kinematic chain I use the methodget_chain
(fromurdf_parser_py
), which returns the sequence of the kinematic tree as [...-link-joint-link-joint-...]Sometimes a link and a joint may have the same name.
Before I was just checking that an element in the chain is in the joints list, supposing that links and joints could not have the same name. For example, if a joint and a link are named
right_elbow
, the check would return that both the elements are in the joints list.To solve this issue I'm allowing the method
get_chain
to return only the joints in the chain.Changing:
with
I'm using this PR also to allow the creation of a link list with only links with inertial properties. With this modification, no fictitious zero inertia is needed. (See #23 (comment))