Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance type annotation, style and improve high_level.Model performance #69

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

flferretti
Copy link
Collaborator

This pull request introduces minor enhancements in type annotations, code style, and performance. In particular, it:

  • speeds up joint_names and link_names methods in the high_level.Model class, also bringing improvements to other internal methods that were dependent on them
  • exposes jaxsim.oop.jax_tf wrapped function arguments type according to PEP 612
  • updates style to the latest black version
  • adds formatting support for Jupyter notebooks in CI

@flferretti flferretti self-assigned this Jan 30, 2024
@flferretti flferretti marked this pull request as ready for review January 31, 2024 10:24
Copy link
Member

@diegoferigo diegoferigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a curiosity.

src/jaxsim/utils/oop.py Show resolved Hide resolved
@flferretti flferretti merged commit a53ac8e into main Jan 31, 2024
19 checks passed
@flferretti flferretti deleted the fix/minor_refactor branch January 31, 2024 11:45
@diegoferigo
Copy link
Member

For the records, as @flferretti noticed, the change we found in 086179a had the consequence to drastically reduce the time CI takes to run the tests, that is mainly JIT compilation time. The key here was replacing some logic computed during runtime (albeit simple) and used pretty often with direct access to a static attribute. Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants