fix: fixes broken host info for remote hosts. fixes #3103

Author: amir20

internal/docker/client.go

@@ -82,25 +82,20 @@ type httpClient struct {
 }
 
 func NewClient(cli DockerCLI, filters filters.Args, host Host) Client {
-	client := &httpClient{
-		cli:     cli,
-		filters: filters,
-		host:    host,
-	}
-	var err error
-	client.info, err = cli.Info(context.Background())
+
+	info, err := cli.Info(context.Background())
 	if err != nil {
 		log.Errorf("unable to get docker info: %v", err)
 	}
 
-	if host.MemTotal == 0 || host.NCPU == 0 {
-		host.NCPU = client.info.NCPU
-		host.MemTotal = client.info.MemTotal
-	}
-
-	log.Debugf("Creating a client with host: %+v", host)
+	host.NCPU = info.NCPU
+	host.MemTotal = info.MemTotal
 
-	return client
+	return &httpClient{
+		cli:     cli,
+		filters: filters,
+		host:    host,
+	}
 }
 
 // NewClientWithFilters creates a new instance of Client with docker filters

internal/docker/host.go

@@ -24,7 +24,7 @@ type Host struct {
 }
 
 func (h Host) String() string {
-	return fmt.Sprintf("ID: %s, Endpoint: %s", h.ID, h.Endpoint)
+	return fmt.Sprintf("ID: %s, Endpoint: %s, nCPU: %d, memTotal: %d", h.ID, h.Endpoint, h.NCPU, h.MemTotal)
 }
 
 func ParseConnection(connection string) (Host, error) {

internal/support/docker/multi_host_service.go

@@ -38,6 +38,8 @@ func NewMultiHostService(clients []ClientService) *MultiHostService {
 		if _, ok := m.clients[client.Host().ID]; ok {
 			log.Warnf("duplicate host %s found, skipping", client.Host())
 			continue
+		} else {
+			log.Debugf("found a new host %s", client.Host())
 		}
 		m.clients[client.Host().ID] = client
 	}